From: André Walker <andre@andrewalker.net>
Date: Mon, 23 Jul 2012 18:35:39 +0000 (-0300)
Subject: setting correct return value for components
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=refs%2Fheads%2Fgsoc_breadboard_split_get_all_components

setting correct return value for components
---

diff --git a/lib/Catalyst.pm b/lib/Catalyst.pm
index 7861b5f..70d6ac3 100644
--- a/lib/Catalyst.pm
+++ b/lib/Catalyst.pm
@@ -1473,13 +1473,10 @@ sub components {
         $container->add_component( $_ ) for keys %$comps;
     }
 
-    # FIXME:
-    # t0m says should be "ref($c) ? $c->container->get_all_singleton_lifecycle_components : $c->container->get_all_components($c)".
-    # are you sure? isn't it the other way around?
-    # i.e. ref($c) ? get_all_components($c) : get_all_singleton_lifecycle_components()
     return
-        ref($class) ? $container->get_all_singleton_lifecycle_components
-                    : $container->get_all_components($class);
+        ref($class) ? $container->get_all_components($class)
+                    : $container->get_all_singleton_lifecycle_components
+                    ;
 }
 
 =head2 $c->context_class