From: Andrew Rodland <andrew@cleverdomain.org>
Date: Mon, 25 Jul 2011 16:38:30 +0000 (-0400)
Subject: Pass options into Handler::FastCGI under preferred names in the script
X-Git-Tag: 5.89003~14
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=fd480b06cb70942a689a0db9a1e6f8af4808c078

Pass options into Handler::FastCGI under preferred names in the script

Map --daemon to 'daemonize' which is preferred instead of 'detach' which
is compat, and --pidfile as 'pid' which is preferred instead of
'pidfile' which is compat.
---

diff --git a/TODO b/TODO
index 5ac46dd..5fcc354 100644
--- a/TODO
+++ b/TODO
@@ -37,12 +37,6 @@ http://github.com/willert/catalyst-plugin-log4perl-simple/tree
 
 #### Script survey
 
-##### myapp_web_fastcgi.pl
-
-Looks to me like we are mapping --deamon to --detach but I think the modern Plack FCGI handler prefers --deamonize
-
-Although --pidfile is supported --pid seems to be preferred, and if we are bothering to map, why not map for the future?
-
 ###  Nice to have
 
   * <@rafl> i've been thinking of maybe providing
diff --git a/lib/Catalyst/Script/FastCGI.pm b/lib/Catalyst/Script/FastCGI.pm
index 1b2a2e9..781c327 100644
--- a/lib/Catalyst/Script/FastCGI.pm
+++ b/lib/Catalyst/Script/FastCGI.pm
@@ -90,8 +90,9 @@ sub _plack_loader_args {
     my ($self) = shift;
 
     my $opts = Data::OptList::mkopt([
-      qw/pidfile manager nproc proc_title/,
-            detach          => [ 'daemon' ],
+      qw/manager nproc proc_title/,
+            pid             => [ 'pidfile' ],
+            daemonize       => [ 'daemon' ],
             keep_stderr     => [ 'keeperr' ],
             listen          => [ '_listen' ],
         ]);