From: Tomas Doran <bobtfish@bobtfish.net>
Date: Tue, 6 Mar 2012 16:30:45 +0000 (+0000)
Subject: Unpossible, but people keep seeing it
X-Git-Tag: 5.90011~1
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=f2b83422bad57b7956d06c7b70098fb986ccf06e;hp=5bf293276098f2b467162c75182eb3bc3f7b0119

Unpossible, but people keep seeing it
---

diff --git a/Changes b/Changes
index d844ca9..f107284 100644
--- a/Changes
+++ b/Changes
@@ -15,6 +15,8 @@
     and other loggers which open a file handle when
   - Change incorrect use of File::Spec->catdir to File::Spec->catfile
     so that we work on platforms which care about this (VMS?)
+  - Make it more obvious if our PSGI server doesn't pass in a response
+    callback.
 
 5.90010 - 2012-02-18 00:01:00
 
diff --git a/lib/Catalyst/Engine.pm b/lib/Catalyst/Engine.pm
index 7b4021c..daf53d1 100644
--- a/lib/Catalyst/Engine.pm
+++ b/lib/Catalyst/Engine.pm
@@ -678,6 +678,7 @@ sub build_psgi_app {
 
         return sub {
             my ($respond) = @_;
+            confess("Did not get a response callback for writer, cannot continiue") unless $respond;
             $app->handle_request(env => $env, response_cb => $respond);
         };
     };