From: Kieren Diment Date: Wed, 4 Apr 2007 00:43:01 +0000 (+0000) Subject: r9568@zaphod (orig r6091): ash | 2007-02-22 04:43:57 +1100 X-Git-Tag: 5.7099_04~195 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=db9db4076abc290049cd3cc41979a55867239388 r9568@zaphod (orig r6091): ash | 2007-02-22 04:43:57 +1100 MyAction attribute - thanks aherzog r9569@zaphod (orig r6092): ash | 2007-02-22 04:53:13 +1100 Add lets add the new file shall we r9590@zaphod (orig r6099): andyg | 2007-02-23 16:54:42 +1100 Improve performance by skipping body processing if we don't have Content-Length r9591@zaphod (orig r6100): andyg | 2007-02-23 16:56:21 +1100 Bump version in C::R r9593@zaphod (orig r6102): andyg | 2007-02-24 02:51:49 +1100 Revert ningu's body change, can't see a good reason for this, and it has no tests r9597@zaphod (orig r6106): andyg | 2007-02-24 07:12:09 +1100 Avoid a call to the slow str2time when setting HTTP Date header r9600@zaphod (orig r6109): andyg | 2007-02-24 10:38:46 +1100 Add a default body to redirect responses r9602@zaphod (orig r6111): andyg | 2007-02-24 16:34:24 +1100 Add tests for body on redirects r9608@zaphod (orig r6117): andyg | 2007-02-27 05:07:01 +1100 Patch from zamolxes: MyApp->model/view now looks at MyApp->config->{default_view/model} r9609@zaphod (orig r6118): andyg | 2007-02-27 05:14:35 +1100 Serve proper HTML for the redirect message r9710@zaphod (orig r6123): andyg | 2007-02-28 17:45:31 +1100 Improved performance and stability of built-in HTTP server. Ripped out keep-alive hack. Increased chunk size from 4K to 64K. r9749@zaphod (orig r6145): andyg | 2007-03-10 06:01:09 +1100 Re-enable keep-alive support in HTTP engine, with a 1-second delay --- diff --git a/Changes b/Changes index 666c785..c547f97 100644 --- a/Changes +++ b/Changes @@ -14,8 +14,8 @@ This file documents the revision history for Perl extension Catalyst. 5.7007 2007-03-13 14:18:00 - Performance and stability improvements to the built-in HTTP server. - - Don't ignore file uploads if form contains a text field with the - same name. (Carl Franks) + - Don't ignore file uploads if form contains a text field with the same name. + (Carl Franks) - Support restart_delay of 0 (for use in the POE engine). - Skip body processing if we don't have a Content-Length header. Results in about a 9% performance increase when handling GET/HEAD diff --git a/lib/Catalyst/Engine/HTTP.pm b/lib/Catalyst/Engine/HTTP.pm index 1bc26b1..6df5345 100644 --- a/lib/Catalyst/Engine/HTTP.pm +++ b/lib/Catalyst/Engine/HTTP.pm @@ -346,8 +346,18 @@ sub _handler { $sel->add( \*STDIN ); REQUEST: - while (1) { - my ( $path, $query_string ) = split /\?/, $uri, 2; + # Initialize CGI environment + local %ENV = ( + PATH_INFO => $path || '', + QUERY_STRING => $query_string || '', + REMOTE_ADDR => $sockdata->{peeraddr}, + REMOTE_HOST => $sockdata->{peername}, + REQUEST_METHOD => $method || '', + SERVER_NAME => $sockdata->{localname}, + SERVER_PORT => $port, + SERVER_PROTOCOL => "HTTP/$protocol", + %copy_of_env, + ); # Initialize CGI environment local %ENV = (