From: Tomas Doran Date: Tue, 2 Aug 2011 20:51:42 +0000 (+0100) Subject: Note I may be wrong here, leave this for now X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=d9661bfabe618bf9c73c03bfcca283690fd148ca Note I may be wrong here, leave this for now --- diff --git a/TODO b/TODO index 38b2d1d..80d1f7b 100644 --- a/TODO +++ b/TODO @@ -162,10 +162,11 @@ after BUILD => sub { - my $accept_context_args = $self->param('accept_context_args'); + my $accept_context_args = $params{accept_context_args}; - ^^ This is wrong! The service should be allowed to mangle the accept_context args, no? + ^^ This (may be) wrong! I am thinking the service should be allowed to mangle the + accept_context args, no? Without this change, the user could make a custom service which mangled the param, and use Catalyst/IOC/Service/WithAcceptContext.pm, with this change, that module will always see the - un-mangled version?? + un-mangled version?? However, without this change, shit doesn't work... accept_context_args - where does this come from?