From: Andy Grundman Date: Fri, 5 Dec 2008 18:05:03 +0000 (+0000) Subject: Workaround max_redirect 0 bug X-Git-Tag: 5.8000_05~113 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=d11e0c1d9eccf6f0fe7f1c2bd0313d5cf742b772;hp=47112c3c6f83242da437b492bc4a609b92a8cd13 Workaround max_redirect 0 bug --- diff --git a/lib/Catalyst/Test.pm b/lib/Catalyst/Test.pm index be452c3..9791b24 100644 --- a/lib/Catalyst/Test.pm +++ b/lib/Catalyst/Test.pm @@ -240,6 +240,10 @@ sub remote_request { keep_alive => 1, max_redirect => 0, timeout => 60, + + # work around newer LWP max_redirect 0 bug + # http://rt.cpan.org/Ticket/Display.html?id=40260 + requests_redirectable => [], ); $agent->env_proxy; diff --git a/t/aggregate/live_engine_response_cookies.t b/t/aggregate/live_engine_response_cookies.t index 59b2a1d..5f2f226 100644 --- a/t/aggregate/live_engine_response_cookies.t +++ b/t/aggregate/live_engine_response_cookies.t @@ -33,8 +33,6 @@ my $expected = { is_deeply( $cookies, $expected, 'Response Cookies' ); } -# XXX: these fail on remote servers due to LWP max_redirect 0 bug: -# http://rt.cpan.org/Ticket/Display.html?id=40260 { ok( my $response = request('http://localhost/engine/response/cookies/two'), 'Request' ); diff --git a/t/aggregate/live_engine_response_redirect.t b/t/aggregate/live_engine_response_redirect.t index 5369bee..a01b9d0 100644 --- a/t/aggregate/live_engine_response_redirect.t +++ b/t/aggregate/live_engine_response_redirect.t @@ -9,8 +9,6 @@ use lib "$FindBin::Bin/../lib"; use Test::More tests => 26; use Catalyst::Test 'TestApp'; -# XXX: these fail on remote servers due to LWP max_redirect 0 bug: -# http://rt.cpan.org/Ticket/Display.html?id=40260 { ok( my $response = request('http://localhost/engine/response/redirect/one'), 'Request' ); ok( $response->is_redirect, 'Response Redirection 3xx' );