From: Tomas Doran Date: Wed, 28 Jul 2010 22:00:05 +0000 (+0000) Subject: Document the horrible, changelog. I'm going to merge this and fix a real issue as... X-Git-Tag: 5.80025~2^2~2 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=d0f30dbc4d81780d345a80328c6f8396084e8ac8 Document the horrible, changelog. I'm going to merge this and fix a real issue as I don't have time to fuck around inside Moose right now and it's been waiting way too long already --- diff --git a/Changes b/Changes index df83fd9..0eee575 100644 --- a/Changes +++ b/Changes @@ -9,6 +9,8 @@ Bug fixes: - Fix the --mech and --mechanize options to the myapp_create.pl script to operate correctly by fixing the options passed down into the script. + - Fix controllers with no method attributes (where the action definitions + are entirely contained in config). RT#58057 Documentation: - Fix missing - in the docs when describing the --mechanize option at one diff --git a/lib/Catalyst/Controller.pm b/lib/Catalyst/Controller.pm index faf4b8e..27b5d0f 100644 --- a/lib/Catalyst/Controller.pm +++ b/lib/Catalyst/Controller.pm @@ -225,6 +225,8 @@ sub register_action_methods { foreach my $method (@methods) { my $name = $method->name; + # Horrible hack! All method metaclasses should have an attributes + # method, core Moose bug - see r13354. my $attributes = $method->can('attributes') ? $method->attributes : []; my $attrs = $self->_parse_attrs( $c, $name, @{ $attributes } ); if ( $attrs->{Private} && ( keys %$attrs > 1 ) ) {