From: Tomas Doran Date: Fri, 5 Dec 2008 08:52:22 +0000 (+0000) Subject: Changelog up to date, make comment re NEXT in the tests more clear, update TODO list... X-Git-Tag: 5.8000_04~4 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=cec7aff62facbd4519a306b57081a557477bee37;hp=094a097487bc728277257b08f556085368a302f3 Changelog up to date, make comment re NEXT in the tests more clear, update TODO list with 5.80 related bits from last night --- diff --git a/Changes b/Changes index c86f86e..62f455b 100644 --- a/Changes +++ b/Changes @@ -1,6 +1,9 @@ # This file documents the revision history for Perl extension Catalyst. 5.8000_04 + - Silence Class::C3::Adopt::NEXT warnings in the test suite (rafl) + - Fix loads of 'used once, possible typo' warnings (rafl) + - Additional tests to ensure upload temp files are deleted (andyg) - Remove use of NEXT from the test suite, except for one case which tests if Class::C3::Adopt::NEXT is working (t0m) - Use a predicate to avoid recursion in cases where the uri diff --git a/TODO b/TODO index d101589..93f92c0 100644 --- a/TODO +++ b/TODO @@ -1,14 +1,16 @@ -TBD pre 5.8000_04 dev release: + - Class::C3::Adopt::NEXT - some people are getting more than one warning + per package, make a test case for this (t0m) - - Simple test for NEXT compat in core (t0m). + - Catalyst::Plugin::Authentication fails tests. Believed to be as + Catalyst::Plugin::Authentication::Credential::Password has a + ->mk_accessors('_config'), which is also class data. + Make a test case for this (t0m) - Looks like stash is not available during prepare_path when running under Catalyst::Test.. Run MojoMojo's t/01app.t and it will explode with "Can't use an undefined value as a HASH reference" - test case for core + fix maybe (marcus) ---- - - Common engine test failures, look into and get tests into core. - Catalyst-Plugin-Authorization-ACL, Can't locate object method "tree" via package "Catalyst::Dispatcher", fix the plugin as tree was never a public method. diff --git a/t/lib/Catalyst/Plugin/Test/Plugin.pm b/t/lib/Catalyst/Plugin/Test/Plugin.pm index 7758bb7..2f7c06d 100644 --- a/t/lib/Catalyst/Plugin/Test/Plugin.pm +++ b/t/lib/Catalyst/Plugin/Test/Plugin.pm @@ -17,9 +17,9 @@ sub prepare { my $class = shift; -# Note: This use of NEXT is deliberately left here to ensure back -# compat, as NEXT always used to be loaded, but is now replaced -# by Class::C3::Adopt::NEXT. +# Note: This use of NEXT is deliberately left here (without a use NEXT) +# to ensure back compat, as NEXT always used to be loaded, but +# is now replaced by Class::C3::Adopt::NEXT. my $c = $class->NEXT::prepare(@_); $c->response->header( 'X-Catalyst-Plugin-Setup' => $c->ran_setup );