From: John Napiorkowski Date: Mon, 21 Oct 2013 15:11:08 +0000 (-0500) Subject: patches from dsteinbrunner X-Git-Tag: 5.90050~1^2~25 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=bd85860bce88aff1548703d761203261b665d9b0;hp=fd5fb3a83e89bd8d5872be6e8cff921a3bb02e78 patches from dsteinbrunner --- diff --git a/lib/Catalyst/Controller.pm b/lib/Catalyst/Controller.pm index d312441..e95bc94 100644 --- a/lib/Catalyst/Controller.pm +++ b/lib/Catalyst/Controller.pm @@ -120,7 +120,7 @@ for more info about how Catalyst dispatches to actions. =cut #I think both of these could be attributes. doesn't really seem like they need -#to ble class data. i think that attributes +default would work just fine +#to be class data. i think that attributes +default would work just fine __PACKAGE__->mk_classdata($_) for qw/_dispatch_steps _action_class _action_role_prefix/; __PACKAGE__->_dispatch_steps( [qw/_BEGIN _AUTO _ACTION/] ); diff --git a/lib/Catalyst/Plugin/Unicode/Encoding.pm b/lib/Catalyst/Plugin/Unicode/Encoding.pm index a689f2c..d22a96f 100644 --- a/lib/Catalyst/Plugin/Unicode/Encoding.pm +++ b/lib/Catalyst/Plugin/Unicode/Encoding.pm @@ -130,12 +130,12 @@ sub setup { my $conf = $self->config; - # Allow an explict undef encoding to disable default of utf-8 + # Allow an explicit undef encoding to disable default of utf-8 my $enc = delete $conf->{encoding}; $self->encoding( $enc ); return $self->next::method(@_) - unless $self->setup_finished; ## hack to stop possibily meaningless test fail... (jnap) + unless $self->setup_finished; ## hack to stop possibly meaningless test fail... (jnap) } sub _handle_unicode_decoding { diff --git a/lib/Catalyst/Upgrading.pod b/lib/Catalyst/Upgrading.pod index 3e2d9d0..03a24ab 100644 --- a/lib/Catalyst/Upgrading.pod +++ b/lib/Catalyst/Upgrading.pod @@ -102,7 +102,7 @@ to use L. The engines that are built upon the various iterations of mod_perl, L (for mod_perl 1, and Apache 1.x) and L (for mod_perl 2, and Apache 2.x), -should be seamless upgrades and will work using using L +should be seamless upgrades and will work using L or L as required. L, however, is no longer supported, as diff --git a/lib/Catalyst/Utils.pm b/lib/Catalyst/Utils.pm index 31773b7..fffa048 100644 --- a/lib/Catalyst/Utils.pm +++ b/lib/Catalyst/Utils.pm @@ -223,7 +223,7 @@ sub home { ( my $path = $inc_entry) =~ s/\.pm$//; my $home = dir($path)->absolute->cleanup; - # return if if it's a valid directory + # return if it's a valid directory return $home->stringify if -d $home; } }