From: Karen Etheridge <ether@cpan.org>
Date: Fri, 19 Oct 2018 05:25:56 +0000 (-0700)
Subject: avoid problematic upload tests on 5.029004+
X-Git-Tag: v5.90120~2
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=b114ef4764de1bc4f492ba9832b3bae3eba2e17c

avoid problematic upload tests on 5.029004+

see RT#125843: sysread cannot be used with :utf8 filehandles
---

diff --git a/Changes b/Changes
index c25c0bd..b21257d 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,8 @@
 # This file documents the revision history for Perl extension Catalyst.
 
+  - avoid problematic test using sysread() on :utf8 filehandles on dev perl
+    versions where this is fatal (starting with 5.29.4). see RT#125843.
+
 5.90119 - 2018-09-24
   - fix test for changes in MooseX::Getopt 0.73 (RT#127050)
 
diff --git a/t/utf_incoming.t b/t/utf_incoming.t
index 9b2b68e..d21137d 100644
--- a/t/utf_incoming.t
+++ b/t/utf_incoming.t
@@ -409,7 +409,9 @@ use Catalyst::Test 'MyApp';
   is $res->content_charset, 'UTF-8';
 }
 
+SKIP:
 {
+  skip 'skipped: sysread isn\'t allowed on :utf8 handles (starting with 5.029004)', 4 if $] >= '5.029004';
   ok my $path = File::Spec->catfile('t', 'utf8.txt');
   ok my $req = POST '/root/file_upload',
     Content_Type => 'form-data',
@@ -419,7 +421,9 @@ use Catalyst::Test 'MyApp';
   is decode_utf8($res->content), "<p>This is stream_body_fh action ♥</p>\n";
 }
 
+SKIP:
 {
+  skip 'skipped: sysread isn\'t allowed on :utf8 handles (starting with 5.029004)', 5 if $] >= '5.029004';
   ok my $path = File::Spec->catfile('t', 'utf8.txt');
   ok my $req = POST '/root/file_upload_utf8_param',
     Content_Type => 'form-data',