From: Tomas Doran Date: Fri, 11 Dec 2009 12:44:55 +0000 (+0000) Subject: Unfuck that as well X-Git-Tag: 5.80016~3 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=ad08ab7583a2b0ecc8d78c0d64b0f737457c82fa Unfuck that as well --- diff --git a/Changes b/Changes index c0f84c4..cfbc0bc 100644 --- a/Changes +++ b/Changes @@ -8,6 +8,7 @@ - The --host option for the server script defaulted to localhost, rather than listening on all interfaces, which was the previous default. (Dave Rolsky) + - Restore -p option for pid file in the FastCGI server script. - Fix the script environment variables MYAPP_PORT and MYAPP_RELOAD RT#52604 - Fix aliasing applications under non-root paths with mod_rewrite in some apache versions where %ENV{SCRIPT_NAME} is set to the real name of diff --git a/lib/Catalyst/Script/FastCGI.pm b/lib/Catalyst/Script/FastCGI.pm index 977bcd6..8bd3c57 100644 --- a/lib/Catalyst/Script/FastCGI.pm +++ b/lib/Catalyst/Script/FastCGI.pm @@ -17,7 +17,7 @@ has listen => ( has pidfile => ( traits => [qw(Getopt)], - cmd_aliases => 'pid', + cmd_aliases => [qw/pid p/], isa => Str, is => 'ro', documentation => 'Specify a pidfile', diff --git a/t/aggregate/unit_core_script_fastcgi.t b/t/aggregate/unit_core_script_fastcgi.t index 7d4da0f..6ffee95 100644 --- a/t/aggregate/unit_core_script_fastcgi.t +++ b/t/aggregate/unit_core_script_fastcgi.t @@ -22,9 +22,10 @@ testOption( [ qw/-l 127.0.0.1:3000/ ], ['127.0.0.1:3000', opthash()] ); testOption( [ qw/-d/ ], [undef, opthash()] ); testOption( [ qw/--daemon/ ], [undef, opthash()] ); -# pidfile -pidfile --pid --pidfile +# pidfile -pidfile -p --pid --pidfile testOption( [ qw/--pidfile cat.pid/ ], [undef, opthash(pidfile => 'cat.pid')] ); testOption( [ qw/--pid cat.pid/ ], [undef, opthash(pidfile => 'cat.pid')] ); +testOption( [ qw/-p cat.pid/ ], [undef, opthash(pidfile => 'cat.pid')] ); # manager testOption( [ qw/--manager foo::bar/ ], [undef, opthash(manager => 'foo::bar')] );