From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Date: Mon, 23 Jan 2017 17:32:18 +0000 (+0000)
Subject: Remove intermediate cruft from ClassData development
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=a439710de6d655c1b276a18dedfacb2056c267d3

Remove intermediate cruft from ClassData development
---

diff --git a/lib/Catalyst/ClassData.pm b/lib/Catalyst/ClassData.pm
index f79149b..e8cb26c 100644
--- a/lib/Catalyst/ClassData.pm
+++ b/lib/Catalyst/ClassData.pm
@@ -10,7 +10,6 @@ sub mk_classdata {
   confess("mk_classdata() is a class method, not an object method")
     if blessed $class;
 
-  my $slot = '$'.$attribute;
   my $accessor =  sub {
     my $pkg = ref $_[0] || $_[0];
     my $meta = Moose::Util::find_meta($pkg)
@@ -21,8 +20,8 @@ sub mk_classdata {
     }
 
     # tighter version of
-    # if ( $meta->has_package_symbol($slot) ) {
-    #   return ${ $meta->get_package_symbol($slot) };
+    # if ( $meta->has_package_symbol('$'.$attribute) ) {
+    #   return ${ $meta->get_package_symbol('$'.$attribute) };
     # }
     no strict 'refs';
     my $v = *{"${pkg}::${attribute}"}{SCALAR};
@@ -41,9 +40,6 @@ sub mk_classdata {
     return;
   };
 
-  confess("Failed to create accessor: $@ ")
-    unless ref $accessor eq 'CODE';
-
   my $meta = $class->Class::MOP::Object::meta();
   confess "${class}'s metaclass is not a Class::MOP::Class"
     unless $meta->isa('Class::MOP::Class');