From: André Walker Date: Sun, 22 Jul 2012 20:26:38 +0000 (-0300) Subject: some todos X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=8c199f8627c2d972d06aa0a98337ff7ba922d9af some todos --- diff --git a/lib/Catalyst/IOC/Container.pm b/lib/Catalyst/IOC/Container.pm index fbc1a7d..b89fd96 100644 --- a/lib/Catalyst/IOC/Container.pm +++ b/lib/Catalyst/IOC/Container.pm @@ -681,6 +681,8 @@ sub _find_component_regexp { # user overrides the container (which is what we want), the sub-container they # will use is precisely $type, not 'component'. So for now, I'm returning both # services, to decide later what to do. +# TODO +# add pod, remove code repetition sub get_all_component_services { my $self = shift; @@ -711,6 +713,8 @@ sub get_all_component_services { return lock_hash %components; } +# TODO +# add pod, remove code repetition sub get_all_singleton_lifecycle_components { my $self = shift; @@ -739,6 +743,8 @@ sub get_all_singleton_lifecycle_components { return lock_hash %components; } +# TODO +# remove code repetition sub get_all_components { my ($self, $class) = @_; my %components; diff --git a/t/aggregate/unit_core_container_get_all_component_services.t b/t/aggregate/unit_core_container_get_all_component_services.t index ffe172b..4b024a4 100644 --- a/t/aggregate/unit_core_container_get_all_component_services.t +++ b/t/aggregate/unit_core_container_get_all_component_services.t @@ -75,6 +75,8 @@ while (my ($class, $info) = each %$expected) { isa_ok($received_info->{backcompat_service}, $info->{bcpt_service_isa}, 'backcompat_service'); } +# TODO +# move this somewhere else, or rename the test my %singleton_component_classes; can_ok($c, 'get_all_singleton_lifecycle_components'); ok(my $singleton_comps = $c->get_all_singleton_lifecycle_components, 'singleton components are fetched');