From: Tomas Doran <bobtfish@bobtfish.net>
Date: Thu, 3 Nov 2011 10:01:55 +0000 (+0000)
Subject: Fix docs in Response, fix Pod tests
X-Git-Tag: 5.90008~16^2~6
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=8738b8fecb20f3761d76a8d7f46660fdae54993a

Fix docs in Response, fix Pod tests
---

diff --git a/lib/Catalyst/Request.pm b/lib/Catalyst/Request.pm
index 3c9dee1..4e000cd 100644
--- a/lib/Catalyst/Request.pm
+++ b/lib/Catalyst/Request.pm
@@ -301,7 +301,7 @@ sub params          { shift->parameters(@_) }
 sub query_params    { shift->query_parameters(@_) }
 sub path_info       { shift->path(@_) }
 
-=for stopwords param params snippets
+=for stopwords param params
 
 =head1 NAME
 
@@ -862,10 +862,22 @@ Add a chunk to the request body.
 
 Sets up parameters from body.
 
-=head2 $self->prepare_cookies($c)
+=head2 $self->prepare_cookies()
 
 Parse cookies from header. Sets up a L<CGI::Simple::Cookie> object.
 
+=head2 $self->prepare_connection()
+
+Sets up various fields in the request like the local and remote addresses,
+request method, vhost requested etc.
+
+=head2 $self->prepare_parameters()
+
+Ensures that the body has been parsed, then builds the parameters, which are
+combined from those in the request and those in the body.
+
+This method is the builder for the 'parameters' attribute.
+
 =head2 meta
 
 Provided by Moose
diff --git a/lib/Catalyst/Response.pm b/lib/Catalyst/Response.pm
index 68ab474..cd81857 100644
--- a/lib/Catalyst/Response.pm
+++ b/lib/Catalyst/Response.pm
@@ -48,12 +48,6 @@ sub output { shift->body(@_) }
 
 sub code   { shift->status(@_) }
 
-=head2 $self->write($buffer)
-
-Writes the buffer to the client.
-
-=cut
-
 sub write {
     my ( $self, $buffer ) = @_;
 
@@ -68,12 +62,6 @@ sub write {
     return $len;
 }
 
-=head2 $self->finalize_headers($c)
-
-Abstract method, allows engines to write headers to response
-
-=cut
-
 sub finalize_headers {
     my ($self) = @_;
 
@@ -258,6 +246,10 @@ Writes $data to the output stream.
 Prints @data to the output stream, separated by $,.  This lets you pass
 the response object to functions that want to write to an L<IO::Handle>.
 
+=head2 $self->finalize_headers($c)
+
+Writes headers to response if not already written
+
 =head2 DEMOLISH
 
 Ensures that the response is flushed and closed at the end of the
diff --git a/t/author/podcoverage.t b/t/author/podcoverage.t
index b43b2df..2875c7d 100644
--- a/t/author/podcoverage.t
+++ b/t/author/podcoverage.t
@@ -10,6 +10,9 @@ our @private = ( 'BUILD' );
 foreach my $module (@modules) {
     local @private = (@private, 'run') if $module =~ /^Catalyst::Script::/;
     local @private = (@private, 'plugin') if $module =~ /^Catalyst$/;
+    local @private = (@private, 'snippets') if $module =~ /^Catalyst::Request$/;
+    local @private = (@private, 'prepare_connection') if $module =~ /^Catalyst::Engine$/;
+
     pod_coverage_ok($module, {
         also_private   => \@private,
         coverage_class => 'Pod::Coverage::TrustPod',