From: Rafael Kitover <rkitover@io.com>
Date: Sat, 30 May 2009 18:33:28 +0000 (+0000)
Subject: component cleanups
X-Git-Tag: 5.80005~11
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=7a5ed4ef58c17ca09a66015b21b402e6853b8d78

component cleanups
---

diff --git a/lib/Catalyst/Component.pm b/lib/Catalyst/Component.pm
index be0d758..1cf664f 100644
--- a/lib/Catalyst/Component.pm
+++ b/lib/Catalyst/Component.pm
@@ -7,6 +7,9 @@ use Catalyst::Utils;
 use Class::C3::Adopt::NEXT;
 use MRO::Compat;
 use mro 'c3';
+use Scalar::Util 'blessed';
+use Storable 'dclone';
+use namespace::clean -except => 'meta';
 
 with 'MooseX::Emulate::Class::Accessor::Fast';
 with 'Catalyst::ClassData';
@@ -59,14 +62,27 @@ __PACKAGE__->mk_classdata('_plugins');
 __PACKAGE__->mk_classdata('_config');
 
 sub BUILDARGS {
-    my ($self) = @_;
-
-    # Temporary fix, some components does not pass context to constructor
-    my $arguments = ( ref( $_[-1] ) eq 'HASH' ) ? $_[-1] : {};
-
-    my $args =  $self->merge_config_hashes( $self->config, $arguments );
+    my $class = shift;
+    my $args = {};
+
+    if (@_ == 1) {
+        $args = $_[0] if ref($_[0]) eq 'HASH';
+    } elsif (@_ == 2) { # is it ($app, $args) or foo => 'bar' ?
+        if (blessed($_[0])) {
+            $args = $_[1] if ref($_[1]) eq 'HASH';
+        } elsif (Class::MOP::is_class_loaded($_[0]) &&
+                $_[0]->isa('Catalyst') && ref($_[1]) eq 'HASH') {
+            $args = $_[1];
+        } elsif ($_[0] == $_[1]) {
+            $args = $_[1];
+        } else {
+            $args = +{ @_ };
+        }
+    } elsif (@_ % 2 == 0) {
+        $args = +{ @_ };
+    }
 
-    return $args;
+    return $class->merge_config_hashes( $class->config, $args );
 }
 
 sub COMPONENT {
@@ -97,15 +113,14 @@ sub config {
         # this is a bit of a kludge, required to make
         # __PACKAGE__->config->{foo} = 'bar';
         # work in a subclass.
+        # TODO maybe this should be a ClassData option?
         my $class = blessed($self) || $self;
         my $meta = Class::MOP::get_metaclass_by_name($class);
         unless ($meta->has_package_symbol('$_config')) {
-
-            $config = $self->merge_config_hashes( $config, {} );
-            $self->_config( $config );
+            $self->_config( dclone $config );
         }
     }
-    return $config;
+    return $self->_config;
 }
 
 sub merge_config_hashes {
@@ -120,9 +135,8 @@ sub process {
           . " did not override Catalyst::Component::process" );
 }
 
-no Moose;
-
 __PACKAGE__->meta->make_immutable;
+
 1;
 
 __END__
@@ -134,7 +148,9 @@ __END__
 Called by COMPONENT to instantiate the component; should return an object
 to be stored in the application's component hash.
 
-=head2 COMPONENT($c, $arguments)
+=head2 COMPONENT
+
+C<< my $component_instance = $component->COMPONENT($app, $arguments); >>
 
 If this method is present (as it is on all Catalyst::Component subclasses,
 it is called by Catalyst during setup_components with the application class
@@ -144,6 +160,15 @@ MyApp->config->{'Controller::Foo'}). The arguments are expected to be a
 hashref and are merged with the __PACKAGE__->config hashref before calling
 ->new to instantiate the component.
 
+You can override it in your components to do custom instantiation, using
+something like this:
+
+  sub COMPONENT {
+      my ($class, $app, $args) = @_;
+      $args = $self->merge_config_hashes($self->config, $args);
+      return $class->new($app, $args);
+  }
+
 =head2 $c->config
 
 =head2 $c->config($hashref)