From: John Napiorkowski <jjn1056@yahoo.com>
Date: Tue, 10 Mar 2015 23:09:29 +0000 (-0500)
Subject: draft / proof of concept
X-Git-Tag: 5.90089_002~50
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=6d62355b6e08f1234fefbdebaacc9ced07b0bc6c

draft / proof of concept
---

diff --git a/lib/Catalyst/Action.pm b/lib/Catalyst/Action.pm
index 881c120..473d595 100644
--- a/lib/Catalyst/Action.pm
+++ b/lib/Catalyst/Action.pm
@@ -21,6 +21,7 @@ L<Catalyst::Controller> subclasses.
 
 use Moose;
 use Scalar::Util 'looks_like_number';
+use Moose::Util::TypeConstraints ();
 with 'MooseX::Emulate::Class::Accessor::Fast';
 use namespace::clean -except => 'meta';
 
@@ -38,6 +39,40 @@ has private_path => (
   default => sub { '/'.shift->reverse },
 );
 
+has args_constraints => (
+  is=>'ro',
+  traits=>['Array'],
+  isa=>'ArrayRef',
+  required=>1,
+  lazy=>1,
+  builder=>'_build_args_constraints',
+  handles => {
+    has_args_constraints => 'count',
+    number_of_args => 'count',
+    all_args_constraints => 'elements',
+  });
+
+  sub _build_args_constraints {
+    my $self = shift;
+    my @arg_protos = @{$self->attributes->{Args}||[]};
+
+    return [] unless scalar(@arg_protos);
+    # If there is only one arg and it looks like a number
+    # we assume its 'classic' and the number is the number of
+    # constraints.
+    my @args = ();
+    if(
+      scalar(@arg_protos) == 1 &&
+      looks_like_number($arg_protos[0])
+    ) {
+      return [];
+    } else {
+      @args = map { Moose::Util::TypeConstraints::find_or_parse_type_constraint($_) || die "$_ is not a constraint!" } @arg_protos;
+    }
+
+    return \@args;
+  }
+
 use overload (
 
     # Stringify to reverse for debug output etc.
@@ -67,35 +102,31 @@ sub execute {
 
 sub match {
     my ( $self, $c ) = @_;
-    #would it be unreasonable to store the number of arguments
-    #the action has as its own attribute?
-    #it would basically eliminate the code below.  ehhh. small fish
-    return 1 unless exists $self->attributes->{Args};
-    my $args = $self->attributes->{Args}[0];
-    return 1 unless defined($args) && length($args);
-    return scalar( @{ $c->req->args } ) == $args;
+    warn "number args = ${\$self->number_of_args} for ${\$self->name}";
+    return 1 unless $self->number_of_args;
+    #my $args = $self->attributes->{Args}[0];
+    #return 1 unless defined($args) && length($args); The "Args" slurpy case, remove for now.
+    if( scalar( @{ $c->req->args } ) == $self->number_of_args ) {
+      return 1 unless $self->has_args_constraints;
+      for my $i($#{ $c->req->args }) {
+        $self->args_constraints->[$i]->check($c->req->args->[$i]) || return 0;
+      }
+      return 1;
+    } else {
+      return 0;
+    }
 }
 
 sub match_captures { 1 }
 
 sub compare {
     my ($a1, $a2) = @_;
-
-    my ($a1_args) = @{ $a1->attributes->{Args} || [] };
-    my ($a2_args) = @{ $a2->attributes->{Args} || [] };
-
-    $_ = looks_like_number($_) ? $_ : ~0
-        for $a1_args, $a2_args;
+    my ($a1_args) = $a1->number_of_args;
+    my ($a2_args) = $a2->number_of_args;
 
     return $a1_args <=> $a2_args;
 }
 
-sub number_of_args {
-    my ( $self ) = @_;
-    return 0 unless exists $self->attributes->{Args};
-    return $self->attributes->{Args}[0];
-}
-
 sub number_of_captures {
     my ( $self ) = @_;
 
diff --git a/lib/Catalyst/DispatchType/Path.pm b/lib/Catalyst/DispatchType/Path.pm
index acf0f3a..38719ea 100644
--- a/lib/Catalyst/DispatchType/Path.pm
+++ b/lib/Catalyst/DispatchType/Path.pm
@@ -56,7 +56,7 @@ sub list {
     );
     foreach my $path ( sort keys %{ $self->_paths } ) {
         foreach my $action ( @{ $self->_paths->{$path} } ) {
-            my $args  = $action->attributes->{Args}->[0];
+            my $args  = $action->number_of_args;
             my $parts = defined($args) ? '/*' x $args : '/...';
 
             my $display_path = "/$path/$parts";
diff --git a/t/arg_constraints.t b/t/arg_constraints.t
index bbc312f..0be8fb8 100644
--- a/t/arg_constraints.t
+++ b/t/arg_constraints.t
@@ -12,8 +12,15 @@ use HTTP::Request::Common;
 
   extends 'Catalyst::Controller';
 
-  sub check :Local {
-    pop->res->from_psgi_response([200, ['Content-Type'=>'text/plain'],['check']]);
+  sub an_int :Local Args(Int) {
+    my ($self, $c, $int) = @_;
+    #use Devel::Dwarn; Dwarn $self;
+    $c->res->body('an_int');
+  }
+
+  sub default :Default {
+    my ($self, $c, $int) = @_;
+    $c->res->body('default');
   }
 
   MyApp::Controller::Root->config(namespace=>'');
@@ -27,10 +34,13 @@ use HTTP::Request::Common;
 use Catalyst::Test 'MyApp';
 
 {
-  my $res = request '/check';
-  is $res->code, 200, 'OK';
-  is $res->content, 'check', 'correct body';
-  is $res->content_length, 5, 'correct length';
+  my $res = request '/an_int/1';
+  is $res->content, 'an_int';
+}
+
+{
+  my $res = request '/an_int/aa';
+  is $res->content, 'default';
 }
 
 done_testing;