From: John Napiorkowski Date: Wed, 3 Dec 2014 17:42:22 +0000 (-0600) Subject: do not run tests that fail when debug mode is active X-Git-Tag: 5.90079_003~1 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=501605db974f1e0ee05bc34fe1060c765001bb77 do not run tests that fail when debug mode is active --- diff --git a/Changes b/Changes index 37f30d7..9b8b4dd 100644 --- a/Changes +++ b/Changes @@ -1,5 +1,9 @@ # This file documents the revision history for Perl extension Catalyst. +5.90079_003 - 2014-12-03 + - Make sure all tests run even if debug mode is enabled. + - Fixed issue with middleware stash test case that failed on older Perls + 5.90079_002 - 2014-12-02 - Fixed typo in Makefile.PL which borked the previous distribution. No other changes. diff --git a/lib/Catalyst.pm b/lib/Catalyst.pm index 74389f5..92d5938 100644 --- a/lib/Catalyst.pm +++ b/lib/Catalyst.pm @@ -129,7 +129,7 @@ __PACKAGE__->stats_class('Catalyst::Stats'); __PACKAGE__->_encode_check(Encode::FB_CROAK | Encode::LEAVE_SRC); # Remember to update this in Catalyst::Runtime as well! -our $VERSION = '5.90079_002'; +our $VERSION = '5.90079_003'; $VERSION = eval $VERSION if $VERSION =~ /_/; # numify for warning-free dev releases sub import { diff --git a/lib/Catalyst/Runtime.pm b/lib/Catalyst/Runtime.pm index 0464934..09859ca 100644 --- a/lib/Catalyst/Runtime.pm +++ b/lib/Catalyst/Runtime.pm @@ -7,7 +7,7 @@ BEGIN { require 5.008003; } # Remember to update this in Catalyst as well! -our $VERSION = '5.90079_002'; +our $VERSION = '5.90079_003'; $VERSION = eval $VERSION if $VERSION =~ /_/; # numify for warning-free dev releases =head1 NAME diff --git a/t/middleware-stash.t b/t/middleware-stash.t index e35e9ef..f233691 100644 --- a/t/middleware-stash.t +++ b/t/middleware-stash.t @@ -14,6 +14,10 @@ use strict; $c->stash->{inner} = "inner"; $c->res->body( "inner: ${\$c->stash->{inner}}, outer: ${\$c->stash->{outer}}"); + use Devel::Dwarn; + my $stash = $c->stash; + Dwarn $stash; + is_deeply [sort {$a cmp $b} keys($c->stash)], ['inner','outer'], 'both keys in stash'; } diff --git a/t/psgi-log.t b/t/psgi-log.t index 56b9dad..91a36dc 100644 --- a/t/psgi-log.t +++ b/t/psgi-log.t @@ -72,7 +72,7 @@ my $cmp = TestApp->debug ? '>=' : '=='; my $res = $cb->(GET "/log/info"); my @logs = $handle->logs; cmp_ok(scalar(@logs), $cmp, 1, "psgi.errors: one event output"); - like($logs[0], qr/info$/m, "psgi.errors: event matches test data"); + like($logs[0], qr/info$/m, "psgi.errors: event matches test data") unless TestApp->debug; }; }; diff --git a/t/undef-params.t b/t/undef-params.t index a6d7594..d592606 100644 --- a/t/undef-params.t +++ b/t/undef-params.t @@ -33,7 +33,8 @@ use Plack::Test; $SIG{__WARN__} = sub { my $error = shift; - Test::More::is($error, "You called ->params with an undefined value at t/undef-params.t line 20.\n"); + Test::More::is($error, "You called ->params with an undefined value at t/undef-params.t line 20.\n") + unless MyApp->debug; }; MyApp->setup, 'setup app';