From: KMX Date: Sun, 6 Dec 2009 20:11:43 +0000 (+0000) Subject: Win32 fix: reverting commit 12210 (after a discussion with t0m) - all tests pass... X-Git-Tag: 5.80016~14 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=4f555202ece37010077ea8ac1a2df58628c2cc36 Win32 fix: reverting commit 12210 (after a discussion with t0m) - all tests pass on Win32/strawberry perl 5.8.9 and 5.10.1 --- diff --git a/Changes b/Changes index e3ba891..97835e9 100644 --- a/Changes +++ b/Changes @@ -3,9 +3,6 @@ Bug fixes: - Fix slurping a file to work correctly with binary on Win32 in the encoding test controller. - - Skip test for outputting the wrong content length when a string - which has been utf-8 upgraded is output on Win32 as there is an - off by one error somewhere. - Allow --restartdirectory as an option for the Server script, for backwards compatibility. (Dave Rolsky) diff --git a/t/aggregate/utf8_content_length.t b/t/aggregate/utf8_content_length.t index a5eacc4..86297e8 100644 --- a/t/aggregate/utf8_content_length.t +++ b/t/aggregate/utf8_content_length.t @@ -20,13 +20,7 @@ my $size = -s $fn; is $r->code, 200, '/binary OK'; is $r->header('Content-Length'), $size, '/binary correct content length'; } -SKIP: { - # Test that even if what is really binary has been upgraded into character - # octets in perl, then when we output it we get the correct content length. - # The issue was initially described in the thread 'Avoiding UTF8 in - # Catalyst': http://lists.scsys.co.uk/pipermail/catalyst/2009-November/023912.html. - # FIXME! (See ml thread re 5.80015 release) - skip 'Known not to work on Win32', 2 if ($^O eq 'MSWin32'); +{ my $r = request('/binary_utf8'); is $r->code, 200, '/binary_utf8 OK'; is $r->header('Content-Length'), $size, '/binary_utf8 correct content length';