From: Alexander Hartmaier <abraxxa@cpan.org>
Date: Mon, 18 Jan 2016 13:03:36 +0000 (+0100)
Subject: log warnings when hostname resolving fails
X-Git-Tag: v5.90123~5^2~1
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=496b73990a36f091b5030fc5e1a8e9d4ae88a861

log warnings when hostname resolving fails
---

diff --git a/lib/Catalyst/Request.pm b/lib/Catalyst/Request.pm
index e937fb1..5dfd7a1 100644
--- a/lib/Catalyst/Request.pm
+++ b/lib/Catalyst/Request.pm
@@ -445,15 +445,21 @@ has hostname => (
         '',
         { flags => AI_NUMERICHOST }
     );
-    return $self->address
-        if $err;
+    if ( $err ) {
+        $self->_log->warn("resolve of hostname failed: $err");
+        return $self->address;
+    }
     ( $err, my $hostname ) = getnameinfo(
         $sockaddr->{addr},
         NI_NAMEREQD,
         # we are only interested in the hostname, not the servicename
         NIx_NOSERV
     );
-    return $err ? $self->address : $hostname;
+    if ( $err ) {
+        $self->_log->warn("resolve of hostname failed: $err");
+        return $self->address;
+    }
+    return $hostname;
   },
 );