From: Tomas Doran Date: Thu, 1 Jan 2009 22:14:42 +0000 (+0000) Subject: Bump Moose dep to fix immutable roundtrip issues, update TODO X-Git-Tag: 5.8000_05~57 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=420453e3f2bd4f6420e98221d12407b6020f5129 Bump Moose dep to fix immutable roundtrip issues, update TODO --- diff --git a/Changes b/Changes index e38714d..ffc36ea 100644 --- a/Changes +++ b/Changes @@ -1,5 +1,6 @@ # This file documents the revision history for Perl extension Catalyst. + - Bump Moose dependency to fix make_immutable bug (t0m) - Use compile time extends in Catalyst::Controller (t0m) - Make Catalyst::Request::uploads attribute non-lazy, to fix test for Catalyst-Engine-Apache (t0m) diff --git a/Makefile.PL b/Makefile.PL index a25ad50..eb5f49a 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -8,7 +8,7 @@ all_from 'lib/Catalyst/Runtime.pm'; requires 'namespace::clean'; requires 'B::Hooks::EndOfScope'; requires 'MooseX::Emulate::Class::Accessor::Fast' => '0.00700'; -requires 'Moose' => '0.59'; +requires 'Moose' => '0.64'; requires 'Carp'; requires 'Class::C3::Adopt::NEXT' => '0.05'; requires 'Class::MOP'; diff --git a/TODO b/TODO index a67d0cb..f5baf32 100644 --- a/TODO +++ b/TODO @@ -3,13 +3,6 @@ Pending patches: Back-compat investigation / known issues: - - Plugins with new methods. - - Moose 'not inlining new method' warnings need to be fixed. - - Warning in Moose could also be more helpful.. - - Why does the current test not fail / warn? - - Generally unhappy with the on_end_of_scope immutable approach, - try removing new method from plugins (and emitting warning). - - Get engines tested: - Catalyst-Engine-Zeus - Catalyst-Engine-XMPP2 @@ -45,7 +38,11 @@ Back-compat investigation / known issues: - In 5.70, you can have a component which doesn't inherit from ::Component, and has no new method, and it'll do the right thing for you. We should still support that, but warn for/deprecate it so it can go for 5.9X... - This all obviously needs better tests :/ + This obviously needs better tests :/ + + - With 5.7 people did extends qw/Moose::Object Catalyst::Component/, now + Catalyst::Component isa Moose::Object so now isa doesn't linearize + anymore, test case.. Cleanups: @@ -60,9 +57,11 @@ Cleanups: - Find whatever in the test suite craps a file called GLOB(0xfoo) onto my disk and fix it. (Believed to be in the optional TEST_HTTP tests?) (t0m) + - Deprecate runtime plugins with warning. + Documentation: - - extends in components must be inside a BEGIN block. + - extends in components with attributes must be inside a BEGIN block. - How to write Moosified Catalyst components.