From: John Napiorkowski Date: Thu, 26 Mar 2015 01:13:59 +0000 (-0500) Subject: removed warning; X-Git-Tag: 5.90089_002~25 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=2a1c08c07e5a7fe716d5bfe897e5b27fc179300a removed warning; --- diff --git a/lib/Catalyst/Action.pm b/lib/Catalyst/Action.pm index 5ee38e9..8c86df0 100644 --- a/lib/Catalyst/Action.pm +++ b/lib/Catalyst/Action.pm @@ -272,8 +272,6 @@ sub execute { sub match { my ( $self, $c ) = @_; - warn $self->reverse; - # If infinite args, we always match return 1 if $self->normalized_arg_number == ~0; diff --git a/lib/Catalyst/ActionRole/HTTPMethods.pm b/lib/Catalyst/ActionRole/HTTPMethods.pm index d0ee99c..9558223 100644 --- a/lib/Catalyst/ActionRole/HTTPMethods.pm +++ b/lib/Catalyst/ActionRole/HTTPMethods.pm @@ -18,7 +18,6 @@ around ['match','match_captures'] => sub { return 0 unless $self->$orig($ctx, @args); my $expected = $ctx->req->method; - warn $expected; return $self->_has_expected_http_method($expected); }; diff --git a/lib/Catalyst/DispatchType/Chained.pm b/lib/Catalyst/DispatchType/Chained.pm index b9d6d07..6705833 100644 --- a/lib/Catalyst/DispatchType/Chained.pm +++ b/lib/Catalyst/DispatchType/Chained.pm @@ -290,6 +290,7 @@ sub recurse_match { next TRY_ACTION unless $action->match($c); } my $args_attr = $action->attributes->{Args}->[0]; + my $args_count = $action->normalized_arg_number; my @pathparts = split /\//, $action->attributes->{PathPart}->[0]; # No best action currently # OR This one matches with fewer parts left than the current best action, @@ -305,12 +306,12 @@ sub recurse_match { !@parts && defined($args_attr) && ( - $args_attr eq "0" && + $args_count eq "0" && ( ($c->config->{use_chained_args_0_special_case}||0) || ( - exists($best_action->{args_attr}) && defined($best_action->{args_attr}) ? - ($best_action->{args_attr} ne 0) : 1 + exists($best_action->{args_count}) && defined($best_action->{args_count}) ? + ($best_action->{args_count} ne 0) : 1 ) ) ) @@ -320,7 +321,7 @@ sub recurse_match { actions => [ $action ], captures=> [], parts => \@parts, - args_attr => $args_attr, + args_count => $args_count, n_pathparts => scalar(@pathparts), }; }