From: Florian Ragwitz <rafl@debian.org>
Date: Sat, 16 Jan 2010 02:06:13 +0000 (+0000)
Subject: We still need to figure out how to not break mod_perl deployments.
X-Git-Tag: 5.89000~37
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=29bb04adc1fd0050a029b50aec57264aad24c1d5

We still need to figure out how to not break mod_perl deployments.
---

diff --git a/TODO b/TODO
index 9575e0a..3680b31 100644
--- a/TODO
+++ b/TODO
@@ -41,6 +41,7 @@ http://github.com/willert/catalyst-plugin-log4perl-simple/tree
   * remove per-request state from the engine instance
   * be smarter about how we use PSGI - not every response needs to be delayed
     and streaming
+  * figure out how to not break existing mod_perl deployments
 
 ##  The horrible hack for plugin setup - replacing it:
 
diff --git a/lib/Catalyst/Engine.pm b/lib/Catalyst/Engine.pm
index 67993f1..0152ebf 100644
--- a/lib/Catalyst/Engine.pm
+++ b/lib/Catalyst/Engine.pm
@@ -754,7 +754,8 @@ run method on the server passed in..
 sub run {
     my ($self, $app, $server, @args) = @_;
     $server ||= Plack::Loader->auto(); # We're not being called from a script,
-                                       # so auto detect mod_perl or whatever
+                                       # so auto detect what backend to run on.
+                                       # This does *NOT* cover mod_perl.
     # FIXME - Do something sensible with the options we're passed
     $server->run($self->build_psgi_app($app, @args));
 }