From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Date: Tue, 14 May 2013 07:38:23 +0000 (+0100)
Subject: Disallow negative counts for CaptureArgs and Args
X-Git-Tag: 5.90040~3^2~10^2~1
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=2782bef25db3c2baa82b2ea34aa12da4c70f21b7

Disallow negative counts for CaptureArgs and Args
---

diff --git a/lib/Catalyst/DispatchType/Chained.pm b/lib/Catalyst/DispatchType/Chained.pm
index 615f5aa..33e23d2 100644
--- a/lib/Catalyst/DispatchType/Chained.pm
+++ b/lib/Catalyst/DispatchType/Chained.pm
@@ -298,7 +298,7 @@ sub _check_args_attr {
     my $args = $action->attributes->{$name}->[0];
     if (defined($args) and not (
         Scalar::Util::looks_like_number($args) and
-        int($args) == $args
+        int($args) == $args and $args >= 0
     )) {
         require Data::Dumper;
         local $Data::Dumper::Terse = 1;
diff --git a/t/dead_load_bad_args.t b/t/dead_load_bad_args.t
index 8542a13..d80195f 100644
--- a/t/dead_load_bad_args.t
+++ b/t/dead_load_bad_args.t
@@ -12,6 +12,7 @@ for my $fail (
     "(' ')",
     "('')",
     "('1.23')",
+    "(-1)",
 ) {
     for my $type (qw(Args CaptureArgs)) {
         eval <<"END";