From: Tomas Doran <bobtfish@bobtfish.net>
Date: Mon, 29 Dec 2008 20:13:23 +0000 (+0000)
Subject: Make Catalyst::Engine::Apaches tests pass.
X-Git-Tag: 5.8000_05~59
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=121b0c3a224819a5b0f59429b57f5abd8ebf5f7e

Make Catalyst::Engine::Apaches tests pass.
---

diff --git a/Changes b/Changes
index 36177a9..ad8e155 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,7 @@
 # This file documents the revision history for Perl extension Catalyst.
 
+        - Make Catalyst::Request::uploads attribute non-lazy, to fix
+          test for Catalyst-Engine-Apache (t0m)
         - Bump version of MooseX::Emulate::Class::Accessor::Fast (t0m)
         - Stop using MooseX::Adopt::Class::Accessor::Fast by default, to stop
           breaking other packages which use Class::Accessor::Fast
diff --git a/TODO b/TODO
index 7b769be..fce0aca 100644
--- a/TODO
+++ b/TODO
@@ -10,7 +10,8 @@ Back-compat investigation / known issues:
     - Generally unhappy with the on_end_of_scope immutable approach,
       try removing new method from plugins (and emitting warning).
 
-  - Common engine test failures, look into and get tests into core.
+  - Engine test failures, look into and update tests / do fixes as
+    needed.
 
   - CatalystX-Imports, Class::MOP doesn't consider anon subs in the symbol 
     table as methods, tests + fix, or explanation and documentation?
@@ -30,10 +31,7 @@ Back-compat investigation / known issues:
      - Catalyst-Plugin-Cache dies due to mk_accessors('meta')
      
      - CatalystX-CRUD fails tests against 5.80 (karpet)
-    
-     - Catalyst-Engine-Apache - Deep recursion on subroutine 
-       "Catalyst::Action::execute", investigate once all other tests pass
-    
+
   - Issues with TWMC not being loaded when it used to be in 5.70 
     (Bill Moseley)
 
diff --git a/lib/Catalyst/Request.pm b/lib/Catalyst/Request.pm
index da5d3e4..fc13ca9 100644
--- a/lib/Catalyst/Request.pm
+++ b/lib/Catalyst/Request.pm
@@ -64,7 +64,6 @@ before body_parameters => sub {
 has uploads => (
   is => 'rw',
   required => 1,
-  lazy => 1,
   default => sub { {} },
 );