From: Andy Grundman <andy@hybridized.org>
Date: Thu, 29 Mar 2007 19:44:12 +0000 (+0000)
Subject: Add a note on the performance of APR::Request
X-Git-Tag: 5.7099_04~204
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=0bf2648c4dcbd7fc6b97b67701ba1425478a6ef9

Add a note on the performance of APR::Request
---

diff --git a/Changes b/Changes
index a5a16ca..dd6d514 100644
--- a/Changes
+++ b/Changes
@@ -5,7 +5,8 @@ This file documents the revision history for Perl extension Catalyst.
           * $c->uri_for (approx. 8x faster)
           * $c->engine->prepare_path (approx. 27x faster)
           * $c->engine->prepare_query_parameters (approx. 5x faster)
-        - If libapreq2 is installed, URIs are decoded using a faster C function.
+        - If libapreq2 is installed, URIs are decoded using a C function that is
+          approx. 12x faster than URI::Escape.
         - Updated HTTP::Body dependency to 0.9 which fixes the following issues:
           * Handle when IE sometimes sends an extra CRLF after the POST body.
           * Empty fields in multipart/form-data POSTs are no longer ignored.
diff --git a/lib/Catalyst/Engine.pm b/lib/Catalyst/Engine.pm
index fea294e..fd22ff0 100644
--- a/lib/Catalyst/Engine.pm
+++ b/lib/Catalyst/Engine.pm
@@ -650,6 +650,7 @@ sub unescape_uri {
     my $self = shift;
     
     if ( HAS_APR ) {
+        # This function is ~12x faster than URI::Escape
         return APR::Request::decode(@_);
     }