From: André Walker Date: Thu, 11 Aug 2011 14:24:59 +0000 (-0300) Subject: catalyst_component_name doesn't have to be a class accessor anymore X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=commitdiff_plain;h=06eea452a21f20243e82ccc96debecc0ed92549c catalyst_component_name doesn't have to be a class accessor anymore --- diff --git a/lib/Catalyst/Component.pm b/lib/Catalyst/Component.pm index 1c61eb2..8a21a46 100644 --- a/lib/Catalyst/Component.pm +++ b/lib/Catalyst/Component.pm @@ -63,14 +63,12 @@ __PACKAGE__->mk_classdata('_config'); has catalyst_component_name => ( is => 'ro' ); # Cannot be required => 1 as context # class @ISA component - HATE -# Make accessor callable as a class method, as we need to call setup_actions -# on the application class, which we don't have an instance of, ewwwww -# Also, naughty modules like Catalyst::View::JSON try to write to _everything_, +# Naughty modules like Catalyst::View::JSON try to write to _everything_, # so spit a warning, ignore that (and try to do the right thing anyway) here.. around catalyst_component_name => sub { my ($orig, $self) = (shift, shift); Carp::cluck("Tried to write to the catalyst_component_name accessor - is your component broken or just mad? (Write ignored - using default value.)") if scalar @_; - blessed($self) ? $self->$orig() || blessed($self) : $self; + return $self->$orig() || blessed($self); }; sub BUILDARGS {