Properly skip known broken tests

Faked passing tests are not cool, and nor are __END__ sections, as those will
break aggregation.

If we actually want to prevent the body of the tests from being compiled,
putting the C<< plan skip_all => ... >> in a BEGIN block is the right thing to
do.

diff --git a/t/aggregate/unit_core_engine_fixenv-iis6.t b/t/aggregate/unit_core_engine_fixenv-iis6.t
index 917a994..776199d 100644 (file)
--- a/t/aggregate/unit_core_engine_fixenv-iis6.t
+++ b/t/aggregate/unit_core_engine_fixenv-iis6.t
@@ -5,10 +5,7 @@ use warnings;
 
 use Test::More;
 
-ok 0, 'Known broken currently';
-done_testing;
-
-__END__
+plan skip_all => 'Known broken currently';
 
 eval "use FCGI";
 plan skip_all => 'FCGI required' if $@;

diff --git a/t/aggregate/unit_core_engine_fixenv-lighttpd.t b/t/aggregate/unit_core_engine_fixenv-lighttpd.t
index da33f3a..ea54e88 100644 (file)
--- a/t/aggregate/unit_core_engine_fixenv-lighttpd.t
+++ b/t/aggregate/unit_core_engine_fixenv-lighttpd.t
@@ -5,10 +5,7 @@ use warnings;
 
 use Test::More;
 
-ok 0, 'Known broken currently';
-done_testing;
-
-__END__
+plan skip_all => 'Known broken currently';
 
 eval "use FCGI";
 plan skip_all => 'FCGI required' if $@;