Added JavaScript to debug screen, to show and hide specific dumps

diff --git a/Changes b/Changes

index b3f4150..32b5904 100644 (file)
--- a/Changes
+++ b/Changes
@@ -1,6 +1,7 @@
 Tis file documents the revision history for Perl extension Catalyst.
 
 5.50
+        - Added JavaScript to debug screen to show and hide specific dumps
         - Added _DISPATCH, _BEGIN, _AUTO, _ACTION and _END actions
         - Added multi process external FastCGI support
           (see myapp_fastcgi.pl -help) (Sam Vilain)
diff --git a/lib/Catalyst/Engine.pm b/lib/Catalyst/Engine.pm

index 2c39782..40d4281 100644 (file)
--- a/lib/Catalyst/Engine.pm
+++ b/lib/Catalyst/Engine.pm
@@ -118,13 +118,27 @@ sub finalize_error {
         my $res   = encode_entities Dumper $c->res;
         my $stash = encode_entities Dumper $c->stash;
 
-        $infos = join(
-            "\n", "<br/>",
-            map {
-                sprintf "<b><u>%s</u></b><br/>\n<pre>%s</pre>", $_->[0],
-                  encode_entities( Dumper $_->[1] )
-              } $c->dump_these
-        );
+        my @infos;
+        my $i = 0;
+        warn "BAAR";
+        for my $dump ( $c->dump_these ) {
+            warn "FOOO";
+            my $name  = $dump->[0];
+            my $value = encode_entities( Dumper $dump->[1] );
+            push @infos, sprintf <<"EOF", $name, $value;
+<div>
+    <b><u>
+        <a href="#" onclick="toggleDump(dump_$i); return false">%s</a>
+    </u></b>
+</div>
+<br/>
+<div id="dump_$i">
+    <pre>%s</pre>
+</div>
+EOF
+            $i++;
+        }
+        $infos = join "\n", @infos;
     }
     else {
         $title = $name;
@@ -147,6 +161,18 @@ sub finalize_error {
 <html>
 <head>
     <title>$title</title>
+    <script language="JavaScript">
+        <!--
+        function toggleDump (dumpElement) {
+            if (dumpElement.style.display == "none") {
+                dumpElement.style.display = "";
+            }
+            else {
+                dumpElement.style.display = "none";
+            }
+        }
+        -->
+    </script>
     <style type="text/css">
         body {
             font-family: "Bitstream Vera Sans", "Trebuchet MS", Verdana,
@@ -156,6 +182,9 @@ sub finalize_error {
             margin: 0px;
             padding: 0px;
         }
+        :link, :link:hover, :visited, :visited:hover {
+            color: #ddd;
+        }
         div.box {
             background-color: #ccc;
             border: 1px solid #aaa;
Changes		patch \| blob \| blame \| history
lib/Catalyst/Engine.pm		patch \| blob \| blame \| history