make predicate on io_fh private

diff --git a/Changes b/Changes
index c65fc7d..f7417d2 100644 (file)
--- a/Changes
+++ b/Changes
@@ -1,5 +1,11 @@
 # This file documents the revision history for Perl extension Catalyst.
 
+TBA
+  - make predicate on ->io_fh private.  Potentially breaking change, but this 
+    method was never documented and is new so this should not be scary.  If you
+    were using $request->has_io_fh, change to ->_has_io_fh (but please consider
+    a different way to do what you are doing...)
+
 5.90049_006 - 2013-11-04
   - Fixed case where test could fail when Starman was partly installed (n0body++)
   - Fixed missing data information in previous release

diff --git a/lib/Catalyst.pm b/lib/Catalyst.pm
index d16779b..b3b6527 100644 (file)
--- a/lib/Catalyst.pm
+++ b/lib/Catalyst.pm
@@ -1837,7 +1837,7 @@ sub finalize {
     # Support skipping finalize for psgix.io style 'jailbreak'.  Used to support
     # stuff like cometd and websockets
     
-    if($c->request->has_io_fh) {
+    if($c->request->_has_io_fh) {
       $c->log_response;
       return;
     }

diff --git a/lib/Catalyst/Request.pm b/lib/Catalyst/Request.pm
index 15f7b7b..b131d4c 100644 (file)
--- a/lib/Catalyst/Request.pm
+++ b/lib/Catalyst/Request.pm
@@ -96,7 +96,7 @@ has _log => (
 
 has io_fh => (
     is=>'ro',
-    predicate=>'has_io_fh',
+    predicate=>'_has_io_fh',
     lazy=>1,
     builder=>'_build_io_fh');