Restructure test to avoid lots of noise when controller returns an error

diff --git a/t/live_fork.t b/t/live_fork.t
index 1fefc2a..c5785a3 100644 (file)
--- a/t/live_fork.t
+++ b/t/live_fork.t
@@ -23,37 +23,47 @@ plan skip_all => 'Using remote server (and REMOTE_FORK not set)'
 plan skip_all => 'Skipping fork tests: no /bin/ls'
     if !-e '/bin/ls'; # see if /bin/ls exists
 
-plan tests => 13; # otherwise
-
 {
     ok(my $result = get('/fork/system/%2Fbin%2Fls'), 'system');
-    my @result = split /$/m, $result;
-    $result = join q{}, @result[-4..-1];
 
-    my $result_ref = eval { Load($result) };
-    ok($result_ref, 'is YAML');
-    is($result_ref->{result}, 0, 'exited OK');
+    if (my $result_ref = result_ok($result)) {
+        ok($result_ref, 'is YAML');
+        is($result_ref->{result}, 0, 'exited OK');
+    }
 }
 
 {
     ok(my $result = get('/fork/backticks/%2Fbin%2Fls'), '`backticks`');
-    my @result = split /$/m, $result;
-    $result = join q{}, @result[-4..-1];
 
-    my $result_ref = eval { Load($result) };
-    ok($result_ref, 'is YAML');
-    is($result_ref->{code}, 0, 'exited successfully');
-    like($result_ref->{result}, qr{^/bin/ls[^:]}, 'contains ^/bin/ls$');
-    like($result_ref->{result}, qr{\n.*\n}m, 'contains two newlines');
+    if (my $result_ref = result_ok($result)) {
+        ok($result_ref, 'is YAML');
+        is($result_ref->{code}, 0, 'exited successfully');
+        like($result_ref->{result}, qr{^/bin/ls[^:]}, 'contains ^/bin/ls$');
+        like($result_ref->{result}, qr{\n.*\n}m, 'contains two newlines');
+    }
 }
+
 {
     ok(my $result = get('/fork/fork'), 'fork');
+
+    if (my $result_ref = result_ok($result)) {
+        ok($result_ref, 'is YAML');
+        isnt($result_ref->{pid}, 0, q{fork's "pid" wasn't 0});
+        isnt($result_ref->{pid}, $$, 'fork got a new pid');
+        is($result_ref->{result}, 'ok', 'fork was effective');
+    }
+}
+
+sub result_ok {
+    my $result = shift;
+
+    unlike( $result, qr/FATAL/, 'result is not an error' )
+        or return;
+
     my @result = split /$/m, $result;
     $result = join q{}, @result[-4..-1];
 
-    my $result_ref = eval { Load($result) };
-    ok($result_ref, 'is YAML');
-    isnt($result_ref->{pid}, 0, q{fork's "pid" wasn't 0});
-    isnt($result_ref->{pid}, $$, 'fork got a new pid');
-    is($result_ref->{result}, 'ok', 'fork was effective');
+    return eval { Load($result) };
 }
+
+done_testing;