# This file documents the revision history for Perl extension Catalyst.
+5.90102 - 2015-10-29
+ - Better warnings when there's an error reading the psgi.input (billmosley++)
+ - Fixed spurious warnings in uri_for when using no arguments (melmothx++ and
+ paultcochrane++)
+
5.90101 - 2015-09-04
- Fixed a regression introduced in the last release which caused test
case failure when using a version of Perl 5.14 or older.
my $fragment = ((scalar(@args) && ref($args[-1]) eq 'SCALAR') ? pop @args : undef );
unless(blessed $path) {
- if ($path =~ s/#(.+)$//) {
+ if (defined($path) and $path =~ s/#(.+)$//) {
if(defined($1) and $fragment) {
carp "Abiguious fragment declaration: You cannot define a fragment in '$path' and as an argument '$fragment'";
}
# Check for definedness as you could read '0'
while ( defined ( my $chunk = $self->read() ) ) {
$self->prepare_body_chunk($chunk);
- $stream_buffer->print($chunk) if $stream_buffer;
+ next unless $stream_buffer;
+
+ $stream_buffer->print($chunk)
+ || die sprintf "Failed to write %d bytes to psgi.input file: $!", length( $chunk );
}
# Ok, we read the body. Lets play nice for any PSGI app down the pipe
);
is(
+ Catalyst::uri_for( $context, '0#fragment', { param1 => 'value1' } )->as_string,
+ 'http://127.0.0.1/foo/yada/0?param1=value1#fragment',
+ 'URI for path 0 with fragment and query params 1'
+);
+
+is(
Catalyst::uri_for( $context, '/bar#fragment^%$', { param1 => 'value1' } )->as_string,
'http://127.0.0.1/foo/bar?param1=value1#fragment^%$',
'URI for path with fragment and query params 3'
Catalyst::uri_for( $context, 'quux', { param1 => $request->base } )->as_string,
'http://127.0.0.1/foo/yada/quux?param1=http%3A%2F%2F127.0.0.1%2Ffoo',
'URI for undef action with query param as object'
-);
+ );
+
+# test with empty arg
+{
+ my @warnings;
+ local $SIG{__WARN__} = sub { push @warnings, @_ };
+ is(
+ Catalyst::uri_for( $context )->as_string,
+ 'http://127.0.0.1/foo/yada',
+ 'URI with no action'
+ );
+
+ is(
+ Catalyst::uri_for( $context, 0 )->as_string,
+ 'http://127.0.0.1/foo/yada/0',
+ 'URI with 0 path'
+ );
+
+ is_deeply(\@warnings, [], "No warnings with no path argument");
+}
$request->base( URI->new('http://localhost:3000/') );
$request->match( 'orderentry/contract' );