why have two loops
Justin Hunter [Fri, 29 May 2009 00:42:33 +0000 (00:42 +0000)]
add Catalyst::Plugin::MangleDollarUnderScore to plugin tests

lib/Catalyst.pm
t/aggregate/live_plugin_loaded.t
t/unit_core_plugin.t

index 137e618..b32c09c 100644 (file)
@@ -2505,11 +2505,8 @@ the plugin name does not begin with C<Catalyst::Plugin::>.
 
         my @plugins = map { s/\A\+// ? $_ : "Catalyst::Plugin::$_" } @$plugins;
         
-        for my $plugin (@plugins) {
-            Class::MOP::load_class($plugin);
-        }
-
         for my $plugin ( reverse @plugins ) {
+            Class::MOP::load_class($plugin);
             my $meta = find_meta($plugin);
             next if $meta && $meta->isa('Moose::Meta::Role');
 
index 835f85c..d5fc317 100644 (file)
@@ -10,6 +10,7 @@ use Test::More tests => 5;
 use Catalyst::Test 'TestApp';
 
 my @expected = qw[
+  Catalyst::Plugin::MangleDollarUnderScore
   Catalyst::Plugin::Test::Errors
   Catalyst::Plugin::Test::Headers
   Catalyst::Plugin::Test::Inline
index cfa3370..09bcfa1 100644 (file)
@@ -42,6 +42,7 @@ is( $warnings, 1, '1 warning' );
 
 use_ok 'TestApp';
 my @expected = qw(
+  Catalyst::Plugin::MangleDollarUnderScore
   Catalyst::Plugin::Test::Errors
   Catalyst::Plugin::Test::Headers
   Catalyst::Plugin::Test::Inline