Restartable app class on perl 5.10. More evil hackery..
Tomas Doran [Tue, 21 Apr 2009 01:40:47 +0000 (01:40 +0000)]
Changes
lib/Catalyst.pm
lib/Catalyst/Engine/HTTP/Restarter/Watcher.pm

diff --git a/Changes b/Changes
index 2e5489c..72aad69 100644 (file)
--- a/Changes
+++ b/Changes
@@ -1,5 +1,7 @@
 # This file documents the revision history for Perl extension Catalyst.
 
+        - Fix issues with restarting the application class due to C3 failures
+          on perl 5.10 (t0m)
         - Work around issues in Moose with initialization order of multiple
           levels of non-Moose classes inheriting from a Moose class (t0m)
           - Test for this
index 52b7787..91239c4 100644 (file)
@@ -1055,10 +1055,11 @@ EOF
     }
 
     # Call plugins setup, this is stupid and evil.
+    # Also screws C3 badly on 5.10, hack to avoid.
     {
         no warnings qw/redefine/;
         local *setup = sub { };
-        $class->setup;
+        $class->setup unless $Catalyst::__AM_RESTARTING;
     }
 
     # Initialize our data structure
index 6aada3e..f1ddc28 100644 (file)
@@ -145,10 +145,15 @@ sub _test {
                 my $is_immutable = $meta->can('is_immutable');
                 my $make_mutable = $meta->can('make_mutable');
                 $meta->$make_mutable() if $is_immutable && $make_mutable && $meta->$is_immutable();
+                eval { # Do not explode the watcher process if this fails.
+                    my $superclasses = $meta->can('superclasses');
+                    $meta->$superclasses('Moose::Object') if $superclasses;
+                };
             }
         });
     }
 
+    local $Catalyst::__AM_RESTARTING = 1; # Hack to avoid C3 fail
     delete $INC{$file}; # Remove from %INC so it will reload
     local $SIG{__WARN__} = sub { };