X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=t%2Funicode_plugin_no_encoding.t;h=feed6810c8a7340c868b594b71824a6bf8387cb4;hp=7b562f8649837b0a25c26150af36a655802d8ec1;hb=161710a39409d2afd256463471b8014a1c69adf4;hpb=9af4ee013b23e7241d4664ea39952fa3b20f4b7f diff --git a/t/unicode_plugin_no_encoding.t b/t/unicode_plugin_no_encoding.t index 7b562f8..feed681 100644 --- a/t/unicode_plugin_no_encoding.t +++ b/t/unicode_plugin_no_encoding.t @@ -18,7 +18,12 @@ my $encode_str = "\x{e3}\x{81}\x{82}"; # e38182 is japanese 'あ' my $decode_str = Encode::decode('utf-8' => $encode_str); my $escape_str = uri_escape_utf8($decode_str); -check_parameter(GET "/?myparam=$escape_str"); +# JNAP - I am removing this test case because I think its not correct. I think +# we do not check the server encoding to determine if the parts of a request URL +# both paths and query should be decoded. I think its always safe to assume utf8 +# encoded urlencoded bits. That is my reading of the spec. Please correct me if +# I am wrong +#check_parameter(GET "/?myparam=$escape_str"); check_parameter(POST '/', Content_Type => 'form-data', Content => [ @@ -33,7 +38,6 @@ sub check_parameter { my ( undef, $c ) = ctx_request(shift); my $myparam = $c->req->param('myparam'); - ok !utf8::is_utf8($myparam); unless ( $c->request->method eq 'POST' ) { is $c->res->output => $encode_str; is $myparam => $encode_str;