X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=t%2Flive_component_controller_action_chained.t;h=a8b7e09ab97f0246ae7ea3f82400e68093379c51;hp=523821d58dcc9e9f8a41e1c6c2d0c619764896a9;hb=2f3812528068bc1d9f7840067f0c03d36cd47e6d;hpb=10ae2631516d23f105f7879aabe54a5033ea629a diff --git a/t/live_component_controller_action_chained.t b/t/live_component_controller_action_chained.t index 523821d..a8b7e09 100644 --- a/t/live_component_controller_action_chained.t +++ b/t/live_component_controller_action_chained.t @@ -8,9 +8,9 @@ use lib "$FindBin::Bin/lib"; our $iters; -BEGIN { $iters = $ENV{CAT_BENCH_ITERS} || 2; } +BEGIN { $iters = $ENV{CAT_BENCH_ITERS} || 1; } -use Test::More tests => 106*$iters; +use Test::More tests => 141*$iters; use Catalyst::Test 'TestApp'; if ( $ENV{CAT_BENCHMARK} ) { @@ -528,6 +528,86 @@ sub run_tests { } # + # Test if :Chained('../act') is working + # + { + my @expected = qw[ + TestApp::Controller::Action::Chained->begin + TestApp::Controller::Action::Chained->one + TestApp::Controller::Action::Chained::ParentChain->chained_rel + TestApp::Controller::Action::Chained->end + ]; + + my $expected = join( ", ", @expected ); + + ok( my $response = request('http://localhost/chained/one/1/chained_rel/3/2'), + ":Chained('../action') chains to correct action" ); + is( $response->header('X-Catalyst-Executed'), + $expected, 'Executed actions' ); + is( $response->content, '1; 3, 2', 'Content OK' ); + } + + # + # Test if ../ works to go up more than one level + # + { + my @expected = qw[ + TestApp::Controller::Action::Chained->begin + TestApp::Controller::Action::Chained->one + TestApp::Controller::Action::Chained::ParentChain::Relative->chained_rel_two + TestApp::Controller::Action::Chained->end + ]; + + my $expected = join( ", ", @expected ); + + ok( my $response = request('http://localhost/chained/one/1/chained_rel_two/42/23'), + "../ works to go up more than one level" ); + is( $response->header('X-Catalyst-Executed'), + $expected, 'Executed actions' ); + is( $response->content, '1; 42, 23', 'Content OK' ); + } + + # + # Test if :ChainedParent is working + # + { + my @expected = qw[ + TestApp::Controller::Action::Chained->begin + TestApp::Controller::Action::Chained->loose + TestApp::Controller::Action::Chained::ParentChain->loose + TestApp::Controller::Action::Chained->end + ]; + + my $expected = join( ", ", @expected ); + + ok( my $response = request('http://localhost/chained/loose/4/loose/a/b'), + ":Chained('../action') chains to correct action" ); + is( $response->header('X-Catalyst-Executed'), + $expected, 'Executed actions' ); + is( $response->content, '4; a, b', 'Content OK' ); + } + + # + # Test if :Chained('../name/act') is working + # + { + my @expected = qw[ + TestApp::Controller::Action::Chained->begin + TestApp::Controller::Action::Chained::Bar->cross1 + TestApp::Controller::Action::Chained::ParentChain->up_down + TestApp::Controller::Action::Chained->end + ]; + + my $expected = join( ", ", @expected ); + + ok( my $response = request('http://localhost/chained/cross/4/up_down/5'), + ":Chained('../action') chains to correct action" ); + is( $response->header('X-Catalyst-Executed'), + $expected, 'Executed actions' ); + is( $response->content, '4; 5', 'Content OK' ); + } + + # # Test behaviour of auto actions returning '1' for the chain. # { @@ -699,7 +779,7 @@ sub run_tests { 'http://localhost/action/chained/to_root' ), 'uri_for with chained root action as arg' ); like( $response->content, - qr(URI:http://[^/]+/), + qr(URI:https?://[^/]+/), 'Correct URI generated' ); } @@ -729,6 +809,24 @@ sub run_tests { } # + # Test chained actions in the root controller + # + { + my @expected = qw[ + TestApp::Controller::Action::Chained::Root->rootsub + TestApp::Controller::Action::Chained::Root->endpointsub + TestApp->end + ]; + + my $expected = join( ", ", @expected ); + + ok( my $response = request('http://localhost/rootsub/1/endpointsub/2'), 'chained in root namespace' ); + is( $response->header('X-Catalyst-Executed'), + $expected, 'Executed actions' ); + is( $response->content, '', 'Content OK' ); + } + + # # Complex path with multiple empty pathparts # { @@ -748,4 +846,139 @@ sub run_tests { is( $response->content, '; ', 'Content OK' ); } + # + # Higher Args() hiding more specific CaptureArgs chains sections + # + { + my @expected = qw[ + TestApp::Controller::Action::Chained->begin + TestApp::Controller::Action::Chained->cc_base + TestApp::Controller::Action::Chained->cc_link + TestApp::Controller::Action::Chained->cc_anchor + TestApp::Controller::Action::Chained->end + ]; + + my $expected = join ', ', @expected; + + ok( my $response = request('http://localhost/chained/choose_capture/anchor.html'), + 'Choose between an early Args() and a later more ideal chain' ); + is( $response->header('X-Catalyst-Executed') => $expected, 'Executed actions'); + is( $response->content => '; ', 'Content OK' ); + } + + # + # Less specific chain not being seen correctly due to earlier looser capture + # + { + my @expected = qw[ + TestApp::Controller::Action::Chained->begin + TestApp::Controller::Action::Chained->cc_base + TestApp::Controller::Action::Chained->cc_b + TestApp::Controller::Action::Chained->cc_b_link + TestApp::Controller::Action::Chained->cc_b_anchor + TestApp::Controller::Action::Chained->end + ]; + + my $expected = join ', ', @expected; + + ok( my $response = request('http://localhost/chained/choose_capture/b/a/anchor.html'), + 'Choose between a more specific chain and an earlier looser one' ); + is( $response->header('X-Catalyst-Executed') => $expected, 'Executed actions'); + is( $response->content => 'a; ', 'Content OK' ); + } + + # + # Check we get the looser one when it's the correct match + # + { + my @expected = qw[ + TestApp::Controller::Action::Chained->begin + TestApp::Controller::Action::Chained->cc_base + TestApp::Controller::Action::Chained->cc_a + TestApp::Controller::Action::Chained->cc_a_link + TestApp::Controller::Action::Chained->cc_a_anchor + TestApp::Controller::Action::Chained->end + ]; + + my $expected = join ', ', @expected; + + ok( my $response = request('http://localhost/chained/choose_capture/a/a/anchor.html'), + 'Choose between a more specific chain and an earlier looser one' ); + is( $response->header('X-Catalyst-Executed') => $expected, 'Executed actions'); + is( $response->content => 'a; anchor.html', 'Content OK' ); + } + + # + # Args(0) should win over Args() if we actually have no arguments. + { + my @expected = qw[ + TestApp::Controller::Action::Chained->begin + TestApp::Controller::Action::Chained::ArgsOrder->base + TestApp::Controller::Action::Chained::ArgsOrder->index + TestApp::Controller::Action::Chained::ArgsOrder->end + ]; + + my $expected = join( ", ", @expected ); + + # With no args, we should run "index" + ok( my $response = request('http://localhost/argsorder/'), + 'Correct arg order ran' ); + is( $response->header('X-Catalyst-Executed'), + $expected, 'Executed actions' ); + is( $response->content, 'base; ; index; ', 'Content OK' ); + + # With args given, run "all" + ok( $response = request('http://localhost/argsorder/X'), + 'Correct arg order ran' ); + is( $response->header('X-Catalyst-Executed'), + join(", ", + qw[ + TestApp::Controller::Action::Chained->begin + TestApp::Controller::Action::Chained::ArgsOrder->base + TestApp::Controller::Action::Chained::ArgsOrder->all + TestApp::Controller::Action::Chained::ArgsOrder->end + ]) + ); + is( $response->content, 'base; ; all; X', 'Content OK' ); + + } + + # + # PathPrefix + # + { + my @expected = qw[ + TestApp::Controller::Action::Chained->begin + TestApp::Controller::Action::Chained::PathPrefix->instance + TestApp::Controller::Action::Chained->end + ]; + + my $expected = join( ", ", @expected ); + + ok( my $response = request('http://localhost/action/chained/pathprefix/1'), + "PathPrefix (as an endpoint)" ); + is( $response->header('X-Catalyst-Executed'), + $expected, 'Executed actions' ); + is( $response->content, '; 1', 'Content OK' ); + } + + # + # static paths vs. captures + # + { + my @expected = qw[ + TestApp::Controller::Action::Chained->begin + TestApp::Controller::Action::Chained->apan + TestApp::Controller::Action::Chained->korv + TestApp::Controller::Action::Chained->static_end + TestApp::Controller::Action::Chained->end + ]; + + my $expected = join( ", ", @expected ); + + ok( my $response = request('http://localhost/action/chained/static_end'), + "static paths are prefered over captures" ); + is( $response->header('X-Catalyst-Executed'), + $expected, 'Executed actions' ); + } }