X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=t%2Faggregate%2Funit_core_uri_for_action.t;h=6f67ccad932f8dad24702852e17ab344c46e5aa0;hp=9b34229366a773c7063d7bd2249635b52c97ffe1;hb=36bac47263176777680ba79b36b60a453386d7ed;hpb=7c1c4dc69062bd372f6611c5a2d3e054cf777d79

diff --git a/t/aggregate/unit_core_uri_for_action.t b/t/aggregate/unit_core_uri_for_action.t
index 9b34229..6f67cca 100644
--- a/t/aggregate/unit_core_uri_for_action.t
+++ b/t/aggregate/unit_core_uri_for_action.t
@@ -1,5 +1,3 @@
-#!perl
-
 use strict;
 use warnings;
 
@@ -36,38 +34,6 @@ ok(!defined($dispatcher->uri_for_action($path_action, [ 'foo' ])),
    "no URI returned for Path action when snippets are given");
 
 #
-#   Regex Action
-#
-my $regex_action = $dispatcher->get_action_by_path(
-                     '/action/regexp/one'
-                   );
-
-ok(!defined($dispatcher->uri_for_action($regex_action)),
-   "Regex action without captures returns undef");
-
-ok(!defined($dispatcher->uri_for_action($regex_action, [ 1, 2, 3 ])),
-   "Regex action with too many captures returns undef");
-
-is($dispatcher->uri_for_action($regex_action, [ 'foo', 123 ]),
-   "/action/regexp/foo/123",
-   "Regex action interpolates captures correctly");
-
-my $regex_action_bs = $dispatcher->get_action_by_path(
-                     '/action/regexp/one_backslashes'
-                   );
-
-ok(!defined($dispatcher->uri_for_action($regex_action_bs)),
-   "Regex action without captures returns undef");
-
-ok(!defined($dispatcher->uri_for_action($regex_action_bs, [ 1, 2, 3 ])),
-   "Regex action with too many captures returns undef");
-
-is($dispatcher->uri_for_action($regex_action_bs, [ 'foo', 123 ]),
-   "/action/regexp/foo/123.html",
-   "Regex action interpolates captures correctly");
-
-
-#
 #   Index Action
 #
 my $index_action = $dispatcher->get_action_by_path(
@@ -111,6 +77,46 @@ my $context = TestApp->new( {
                 namespace => 'yada',
               } );
 
+
+
+
+# JNAP: I'm going to todo these tests, calling uri_for as a class method
+# should work, but its not really useful so I think theres not much harm
+# if someone needs this for a business case they are welcome to figure out
+# what is going 
+
+TODO: {
+    local $TODO = "Need to fix using uri_for and uri_for_action as a class method";
+            
+
+# this works, using $ctx
+is($context->uri_for($context->controller('Action::Chained')->action_for('endpoint')),
+   "http://127.0.0.1/foo/yada/chained/foo/end",
+   "uri_for a controller and action");
+
+
+# this fails, uri_for returns undef, why isn't this one working??
+  is( $context->uri_for_action( '/action/chained/endpoint' ),
+          'http://127.0.0.1/chained/foo/end',
+     "uri_for a controller and action as string");
+
+# this fails, uri_for returns undef
+  is(TestApp->uri_for_action($context->controller('Action::Chained')->action_for('endpoint')),
+     "/chained/foo/end",
+     "uri_for a controller and action, called with only class name");
+
+# this fails, uri_for returns undef
+  is(TestApp->uri_for_action('/action/chained/endpoint' ),
+     "/chained/foo/end",
+     "uri_for a controller and action as string, called with only class name");
+
+# this fails, uri_for returns undef
+  is(TestApp->uri_for_action(  $chained_action),
+     "/chained/foo/end",
+     "uri_for action via dispatcher, called with only class name");
+}
+
+
 is($context->uri_for($context->controller('Action')),
    "http://127.0.0.1/foo/yada/action/",
    "uri_for a controller");
@@ -126,10 +132,6 @@ is($context->uri_for($path_action, qw/one two/, { q => 1 }),
 ok(!defined($context->uri_for($path_action, [ 'blah' ])),
    "no URI returned by uri_for for Path action with snippets");
 
-is($context->uri_for($regex_action, [ 'foo', 123 ], qw/bar baz/, { q => 1 }),
-   "http://127.0.0.1/foo/action/regexp/foo/123/bar/baz?q=1",
-   "uri_for correct for regex with captures, args and query");
-
 is($context->uri_for($chained_action, [ 1 ], 2, { q => 1 }),
    "http://127.0.0.1/foo/chained/foo/1/end/2?q=1",
    "uri_for correct for chained with captures, args and query");