X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=lib%2FCatalyst%2FUpgrading.pod;h=487787a9fdbe76b3e66e7aef6a80d0884f8fe0af;hp=0d1a60b521db8272022af123bc77643cb1365683;hb=a1dba4cf60acfe8c592a80dad86a076cd3eb1dec;hpb=044e7667c0cb0cd8dac8b33df1d503abdab0d70c diff --git a/lib/Catalyst/Upgrading.pod b/lib/Catalyst/Upgrading.pod index 0d1a60b..487787a 100644 --- a/lib/Catalyst/Upgrading.pod +++ b/lib/Catalyst/Upgrading.pod @@ -2,6 +2,57 @@ Catalyst::Upgrading - Instructions for upgrading to the latest Catalyst +=head1 Upgrading to Catalyst 5.90097 + +In older versions of Catalyst one could construct a L with a fragment (such as +https://localhost/foo/bar#fragment) by using a '#' in the path or final argument, for +example: + + $c->uri_for($action, 'foo#fragment'); + +This behavior was never documented and would break if using the Unicode plugin, or when +adding a query to the arguments: + + $c->uri_for($action, 'foo#fragment', +{ a=>1, b=>2}); + +would define a fragment like "#fragment?a=1&b=2". + +When we introduced UTF-8 encoding by default in Catalyst 5.9008x this side effect behavior +was broken since we started encoding the '#' when it was part of the URI path. + +In version 5.90095 and 5.90096 we attempted to fix this, but all we managed to do was break +people with URIs that included '#' as part of the path data, when it was not expected to +be a fragment delimiter. + +In general L prefers an explicit specification rather than relying on side effects +or domain specific mini languages. As a result we are now defining how to set a fragment +for a URI via ->uri_for: + + $c->uri_for($action_or_path, \@captures_or_args, @args, \$query, \$fragment); + +If you are relying on the previous side effect behavior your URLs will now encode the '#' +delimiter, which is going to be a breaking change for you. You need to alter your code +to match the new specification or modify uri_for for your local case. Patches to solve +this are very welcomed, as long as they don't break existing test cases. + +B If you are using the string form of the first argument: + + $c->uri_for('/foo/bar#baz') + +construction, we do not attempt to encode this and it will make a URL with a +fragment of 'baz'. + + +=head1 Upgrading to Catalyst 5.90095 + +The method C in L was actually returning the first error. This has +been fixed but there is a small chance it could be a breaking issue for you. If this gives +you trouble changing to C is the easiest workaround (although that does +modify the error stack so if you are relying on that not being changed you should try something +like @{$c->errors}[-1] instead. Since this method is relatively new and the cases when the +error stack actually has more than one error in it, we feel the exposure is very low, but bug +reports are very welcomed. + =head1 Upgrading to Catalyst 5.90090 L has a new method 'inject_component' which works the same as the method of