X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=lib%2FCatalyst%2FTest.pm;h=53c16a203e9265e4ff65d427d799f2afe026c6df;hp=492fb31dbeab280aaa3ce6e68321916f68048195;hb=d0cacee71a316290bc01f0e12681c16bdc1e84e2;hpb=949f330d1f0f7d5fc868ddeb6f338733a2dfa39f diff --git a/lib/Catalyst/Test.pm b/lib/Catalyst/Test.pm index 492fb31..53c16a2 100644 --- a/lib/Catalyst/Test.pm +++ b/lib/Catalyst/Test.pm @@ -295,21 +295,28 @@ sub _local_request { # HTML head parsing based on LWP::UserAgent # + # This is because if you make a remote request with LWP, then the + # from the returned HTML document will be used + # to fill in $res->base, as documented in HTTP::Response. We need + # to support this in local test requests so that they work 'the same'. + # # This is not just horrible and possibly broken, but also really # doesn't belong here. Whoever wants this should be working on # getting it into Plack::Test, or make a middleware out of it, or # whatever. Seriously - horrible. - require HTML::HeadParser; + if (!$resp->content_type || $resp->content_is_html) { + require HTML::HeadParser; - my $parser = HTML::HeadParser->new(); - $parser->xml_mode(1) if $resp->content_is_xhtml; - $parser->utf8_mode(1) if $] >= 5.008 && $HTML::Parser::VERSION >= 3.40; + my $parser = HTML::HeadParser->new(); + $parser->xml_mode(1) if $resp->content_is_xhtml; + $parser->utf8_mode(1) if $] >= 5.008 && $HTML::Parser::VERSION >= 3.40; - $parser->parse( $resp->content ); - my $h = $parser->header; - for my $f ( $h->header_field_names ) { - $resp->init_header( $f, [ $h->header($f) ] ); + $parser->parse( $resp->content ); + my $h = $parser->header; + for my $f ( $h->header_field_names ) { + $resp->init_header( $f, [ $h->header($f) ] ); + } } # Another horrible hack to make the response headers have a # 'status' field. This is for back-compat, but you should