X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=lib%2FCatalyst%2FEngine.pm;h=79ecbb80cd1544ad991e4514f78a518ae5c9d736;hp=86eb91bedd60f7088b8095f4a6db38fa31c3d58f;hb=e060fe05e8770527de1f433b4ae4bc2cd1e8c303;hpb=d70195d8eedf0d77f77410ba32e12bc8f4138413
diff --git a/lib/Catalyst/Engine.pm b/lib/Catalyst/Engine.pm
index 86eb91b..79ecbb8 100644
--- a/lib/Catalyst/Engine.pm
+++ b/lib/Catalyst/Engine.pm
@@ -26,6 +26,9 @@ __PACKAGE__->mk_accessors(qw/request response state/);
*req = \&request;
*res = \&response;
+# For backwards compatibility
+*finalize_output = \&finalize_body;
+
# For statistics
our $COUNT = 1;
our $START = time;
@@ -176,20 +179,28 @@ sub finalize {
$c->finalize_error;
}
- if ( !$c->response->output && $c->response->status !~ /^(1|3)\d\d$/ ) {
+ if ( !$c->response->body && $c->response->status !~ /^(1|3)\d\d$/ ) {
$c->finalize_error;
}
- if ( $c->response->output && !$c->response->content_length ) {
+ if ( $c->response->body && !$c->response->content_length ) {
use bytes; # play safe with a utf8 aware perl
- $c->response->content_length( length $c->response->output );
+ $c->response->content_length( length $c->response->body );
}
my $status = $c->finalize_headers;
- $c->finalize_output;
+ $c->finalize_body;
return $status;
}
+=item $c->finalize_body
+
+Finalize body.
+
+=cut
+
+sub finalize_body { }
+
=item $c->finalize_cookies
Finalize cookies.
@@ -260,7 +271,7 @@ sub finalize_error {
$name = '';
}
- $c->res->output( <<"" );
+ $c->res->body( <<"" );
$title
@@ -324,14 +335,6 @@ Finalize headers.
sub finalize_headers { }
-=item $c->finalize_output
-
-Finalize output.
-
-=cut
-
-sub finalize_output { }
-
=item $c->handler( $class, $r )
Handles the request.
@@ -422,16 +425,33 @@ sub prepare {
$c->prepare_headers;
$c->prepare_cookies;
$c->prepare_connection;
+ $c->prepare_action;
my $method = $c->req->method || '';
my $path = $c->req->path || '';
my $hostname = $c->req->hostname || '';
my $address = $c->req->address || '';
+
$c->log->debug(qq/"$method" request for "$path" from $hostname($address)/)
if $c->debug;
- $c->prepare_action;
- $c->prepare_parameters;
+ if ( $c->request->method eq 'POST' and $c->request->content_length ) {
+
+ if ( $c->req->content_type eq 'application/x-www-form-urlencoded' ) {
+ $c->prepare_parameters;
+ }
+ elsif ( $c->req->content_type eq 'multipart/form-data' ) {
+ $c->prepare_parameters;
+ $c->prepare_uploads;
+ }
+ else {
+ $c->prepare_body;
+ }
+ }
+
+ if ( $c->request->method eq 'GET' ) {
+ $c->prepare_parameters;
+ }
if ( $c->debug && keys %{ $c->req->params } ) {
my $t = Text::ASCIITable->new;
@@ -445,7 +465,6 @@ sub prepare {
$c->log->debug( 'Parameters are', $t->draw );
}
- $c->prepare_uploads;
return $c;
}
@@ -499,6 +518,14 @@ sub prepare_action {
if ( $c->debug && @args );
}
+=item $c->prepare_body
+
+Prepare message body.
+
+=cut
+
+sub prepare_body { }
+
=item $c->prepare_connection
Prepare connection.
@@ -669,9 +696,6 @@ sub stash {
return $self->{stash};
}
-# Takes a coderef and returns an arrayref containing attributes
-sub _get_attrs { attributes::get( $_[0] ) || [] }
-
=back
=head1 AUTHOR