X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=lib%2FCatalyst%2FEngine.pm;h=44c9c126de58805feffbf2aad345286c111efca6;hp=cd0d3838fcdfc6c1fbee762e600ca067e50a3d7f;hb=2a2b8f6504e0e8adc7d7b78435ffdcd27c37fc15;hpb=d200092825d92139d59f660eaa895790442cdf8b diff --git a/lib/Catalyst/Engine.pm b/lib/Catalyst/Engine.pm index cd0d383..44c9c12 100644 --- a/lib/Catalyst/Engine.pm +++ b/lib/Catalyst/Engine.pm @@ -574,14 +574,6 @@ sub prepare_query_parameters { my ($self, $c) = @_; my $env = $c->request->env; - if(my $query_obj = $env->{'plack.request.query'}) { - $c->request->query_parameters( - $c->request->_use_hash_multivalue ? - $query_obj->clone : - $query_obj->as_hashref_mixed); - return; - } - my $query_string = exists $env->{QUERY_STRING} ? $env->{QUERY_STRING} : ''; @@ -595,41 +587,15 @@ sub prepare_query_parameters { return; } - my %query; - - # replace semi-colons - $query_string =~ s/;/&/g; - - my @params = grep { length $_ } split /&/, $query_string; - - for my $item ( @params ) { - - my ($param, $value) - = map { decode_utf8($self->unescape_uri($_)) } - split( /=/, $item, 2 ); - - unless(defined $param) { - $param = $self->unescape_uri($item); - $param = decode_utf8 $param; - } + $query_string =~ s/\A[&;]+//; - if ( exists $query{$param} ) { - if ( ref $query{$param} ) { - push @{ $query{$param} }, $value; - } - else { - $query{$param} = [ $query{$param}, $value ]; - } - } - else { - $query{$param} = $value; - } - } + my $p = Hash::MultiValue->new( + map { defined $_ ? decode_utf8($self->unescape_uri($_)) : $_ } + map { ( split /=/, $_, 2 )[0,1] } # slice forces two elements + split /[&;]+/, $query_string + ); - $c->request->query_parameters( - $c->request->_use_hash_multivalue ? - Hash::MultiValue->from_mixed(\%query) : - \%query); + $c->request->query_parameters( $c->request->_use_hash_multivalue ? $p : $p->mixed ); } =head2 $self->prepare_read($c)