X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=lib%2FCatalyst%2FDispatcher.pm;h=ac641a95dddef741bd62586ff3ed5ec43f80c20e;hp=1b648431b0458c1491b0fdce43ec8557ca91b9e4;hb=b5ecfcf07b8ffe7e9984f0279c8781ce51c6ac6a;hpb=138ce4c03ae1ffaf58c721057b3f37486ffbc178 diff --git a/lib/Catalyst/Dispatcher.pm b/lib/Catalyst/Dispatcher.pm index 1b64843..ac641a9 100644 --- a/lib/Catalyst/Dispatcher.pm +++ b/lib/Catalyst/Dispatcher.pm @@ -38,9 +38,7 @@ See L. =head1 METHODS -=over 4 - -=item $self->detach( $c, $command [, \@arguments ] ) +=head2 $self->detach( $c, $command [, \@arguments ] ) =cut @@ -50,13 +48,12 @@ sub detach { die $Catalyst::DETACH; } -=item $self->dispatch($c) +=head2 $self->dispatch($c) =cut sub dispatch { my ( $self, $c ) = @_; - if ( $c->action ) { $c->forward( join( '/', '', $c->action->namespace, '_DISPATCH' ) ); } @@ -71,7 +68,7 @@ sub dispatch { } } -=item $self->forward( $c, $command [, \@arguments ] ) +=head2 $self->forward( $c, $command [, \@arguments ] ) =cut @@ -86,10 +83,10 @@ sub forward { } my $local_args = 0; - my $arguments = []; + my $arguments = $c->req->args; if ( ref( $_[-1] ) eq 'ARRAY' ) { - $arguments = pop(@_); - $local_args++; + $arguments = pop(@_); + $local_args = 1; } my $result; @@ -111,12 +108,9 @@ sub forward { my $tail = $2; $result = $c->get_action( $tail, $1 ); if ($result) { - $command = $tail; - if ($local_args) { unshift( @{$arguments}, @extra_args ) } - else { - $local_args++; - $arguments = \@extra_args; - } + $local_args = 1; + $command = $tail; + unshift( @{$arguments}, @extra_args ); last DESCEND; } unshift( @extra_args, $tail ); @@ -163,14 +157,16 @@ qq/Couldn't forward to command "$command". Invalid action or component./; } - if ($local_args) { local $c->request->{arguments} = [ @{$arguments} ] } - - $result->execute($c); + if ($local_args) { + local $c->request->{arguments} = [ @{$arguments} ]; + $result->execute($c); + } + else { $result->execute($c) } return $c->state; } -=item $self->prepare_action($c) +=head2 $self->prepare_action($c) =cut @@ -195,15 +191,17 @@ sub prepare_action { } # If not, move the last part path to args - unshift @args, pop @path; } + $c->log->debug( 'Path is "' . $c->req->match . '"' ) + if ( $c->debug && $c->req->match ); + $c->log->debug( 'Arguments are "' . join( '/', @args ) . '"' ) if ( $c->debug && @args ); } -=item $self->get_action( $action, $namespace ) +=head2 $self->get_action( $action, $namespace ) =cut @@ -222,7 +220,7 @@ sub get_action { } } -=item $self->get_actions( $c, $action, $namespace ) +=head2 $self->get_actions( $c, $action, $namespace ) =cut @@ -237,7 +235,7 @@ sub get_actions { return map { $_->get_action($action) } @match; } -=item $self->get_containers( $namespace ) +=head2 $self->get_containers( $namespace ) =cut @@ -279,7 +277,7 @@ sub get_containers { return map { $_->getNodeValue } @match; } -=item $self->register( $c, $action ) +=head2 $self->register( $c, $action ) =cut @@ -339,7 +337,7 @@ sub register { $parent->getNodeValue->actions->{ $action->name } = $action; } -=item $self->setup_actions( $class, $component ) +=head2 $self->setup_actions( $class, $component ) =cut @@ -414,8 +412,6 @@ sub setup_actions { $_->list($c) for @{ $self->dispatch_types }; } -=back - =head1 AUTHOR Sebastian Riedel, C