X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=lib%2FCatalyst%2FDispatchType%2FPath.pm;h=bff5f212f0cc37397265da4e7394d3fd77c2894b;hp=b51f06ce5095e82c3d6a6cd5c4a3beb161e1fac6;hb=5299fff8fe52a4f4c10698b258984e41a2f6964f;hpb=cdf573a6d9c22e23e322b3a4e8ed1dbd189c3304 diff --git a/lib/Catalyst/DispatchType/Path.pm b/lib/Catalyst/DispatchType/Path.pm index b51f06c..bff5f21 100644 --- a/lib/Catalyst/DispatchType/Path.pm +++ b/lib/Catalyst/DispatchType/Path.pm @@ -6,7 +6,6 @@ extends 'Catalyst::DispatchType'; use Text::SimpleTable; use Catalyst::Utils; use URI; -use Scalar::Util (); has _paths => ( is => 'rw', @@ -49,7 +48,7 @@ Debug output for Path dispatch points sub list { my ( $self, $c ) = @_; my $column_width = Catalyst::Utils::term_width() - 35 - 9; - my $paths = Text::SimpleTable->new( + my $paths = Text::SimpleTable->new( [ 35, 'Path' ], [ $column_width, 'Private' ] ); foreach my $path ( sort keys %{ $self->_paths } ) { @@ -62,16 +61,6 @@ sub list { if ( keys %{ $self->_paths } ); } -sub _action_args_sort_order { - my ( $self, $action ) = @_; - - my ($args) = @{ $action->attributes->{Args} || [] }; - - return $args if Scalar::Util::looks_like_number($args); - - return ~0; -} - =head2 $self->match( $c, $path ) For each action registered to this exact path, offers the action a chance to @@ -85,10 +74,7 @@ sub match { $path = '/' if !defined $path || !length $path; - # sort from least args to most - my @actions = sort { $self->_action_args_sort_order($a) <=> - $self->_action_args_sort_order($b) } - @{ $self->_paths->{$path} || [] }; + my @actions = @{ $self->_paths->{$path} || [] }; foreach my $action ( @actions ) { next unless $action->match($c); @@ -130,8 +116,11 @@ sub register_path { $path =~ s!^/!!; $path = '/' unless length $path; $path = URI->new($path)->canonical; + $path =~ s{(?<=[^/])/+\z}{}; - unshift( @{ $self->_paths->{$path} ||= [] }, $action); + $self->_paths->{$path} = [ + sort { $a <=> $b } ($action, @{ $self->_paths->{$path} || [] }) + ]; return 1; } @@ -165,7 +154,7 @@ Catalyst Contributors, see Catalyst.pm =head1 COPYRIGHT -This program is free software, you can redistribute it and/or modify it under +This library is free software. You can redistribute it and/or modify it under the same terms as Perl itself. =cut