X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=lib%2FCatalyst%2FDispatchType%2FPath.pm;h=acf0f3a4be00107193bb730094f16ed517c40602;hp=29c418ffdbad42f7e4afc42a838abb5ed826c75b;hb=0ca510f0aa1cabe138d81897d38111d7b772449c;hpb=b9b89145c40b01ae04dc483f4f29c02cf08725be diff --git a/lib/Catalyst/DispatchType/Path.pm b/lib/Catalyst/DispatchType/Path.pm index 29c418f..acf0f3a 100644 --- a/lib/Catalyst/DispatchType/Path.pm +++ b/lib/Catalyst/DispatchType/Path.pm @@ -6,6 +6,7 @@ extends 'Catalyst::DispatchType'; use Text::SimpleTable; use Catalyst::Utils; use URI; +use Encode 2.21 'decode_utf8'; has _paths => ( is => 'rw', @@ -47,13 +48,21 @@ Debug output for Path dispatch points sub list { my ( $self, $c ) = @_; - my $column_width = Catalyst::Utils::term_width() - 35 - 9; - my $paths = Text::SimpleTable->new( - [ 35, 'Path' ], [ $column_width, 'Private' ] + my $avail_width = Catalyst::Utils::term_width() - 9; + my $col1_width = ($avail_width * .50) < 35 ? 35 : int($avail_width * .50); + my $col2_width = $avail_width - $col1_width; + my $paths = Text::SimpleTable->new( + [ $col1_width, 'Path' ], [ $col2_width, 'Private' ] ); foreach my $path ( sort keys %{ $self->_paths } ) { - my $display_path = $path eq '/' ? $path : "/$path"; foreach my $action ( @{ $self->_paths->{$path} } ) { + my $args = $action->attributes->{Args}->[0]; + my $parts = defined($args) ? '/*' x $args : '/...'; + + my $display_path = "/$path/$parts"; + $display_path =~ s{/{1,}}{/}g; + $display_path =~ s/%([0-9A-Fa-f]{2})/chr(hex($1))/eg; # deconvert urlencoded for pretty view + $display_path = decode_utf8 $display_path; # URI does encoding $paths->row( $display_path, "/$action" ); } } @@ -74,7 +83,9 @@ sub match { $path = '/' if !defined $path || !length $path; - foreach my $action ( @{ $self->_paths->{$path} || [] } ) { + my @actions = @{ $self->_paths->{$path} || [] }; + + foreach my $action ( @actions ) { next unless $action->match($c); $c->req->action($path); $c->req->match($path); @@ -114,8 +125,11 @@ sub register_path { $path =~ s!^/!!; $path = '/' unless length $path; $path = URI->new($path)->canonical; + $path =~ s{(?<=[^/])/+\z}{}; - unshift( @{ $self->_paths->{$path} ||= [] }, $action); + $self->_paths->{$path} = [ + sort { $a->compare($b) } ($action, @{ $self->_paths->{$path} || [] }) + ]; return 1; } @@ -149,7 +163,7 @@ Catalyst Contributors, see Catalyst.pm =head1 COPYRIGHT -This program is free software, you can redistribute it and/or modify it under +This library is free software. You can redistribute it and/or modify it under the same terms as Perl itself. =cut