X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=lib%2FCatalyst%2FController.pm;h=c8db2e7a1bb0ded993de5a3c47f08771eaf4ca85;hp=37e36e10bad9ebb211f4373e29ed5cbd74fc93a1;hb=d2598ac82e8508f4d6da90ec60a1ed60840c2016;hpb=829b22f766b0b1d1a09a6ce152abe48ad9bde5ec diff --git a/lib/Catalyst/Controller.pm b/lib/Catalyst/Controller.pm index 37e36e1..c8db2e7 100644 --- a/lib/Catalyst/Controller.pm +++ b/lib/Catalyst/Controller.pm @@ -156,7 +156,7 @@ around action_namespace => sub { } } - my $namespace = Catalyst::Utils::class2prefix(ref($self) ? $self->_component_name : $self, $case_s) || ''; + my $namespace = Catalyst::Utils::class2prefix($self->_component_name, $case_s) || ''; $self->$orig($namespace) if ref($self); return $namespace; }; @@ -207,10 +207,15 @@ sub register_actions { sub register_action_methods { my ( $self, $c, @methods ) = @_; - my $class = blessed($self) ? $self->_component_name : $self; + my $class = $self->_component_name; #this is still not correct for some reason. my $namespace = $self->action_namespace($c); + # Uncomment as soon as you fix the tests :) + #if (!blessed($self) && $self eq $c && scalar(@methods)) { + # $c->log->warn("Action methods found defined in your application class, $self. This is deprecated, please move them into a Root controller."); + #} + foreach my $method (@methods) { my $name = $method->name; my $attributes = $method->attributes;