X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=lib%2FCatalyst%2FController.pm;h=2e58312c903062b567ada8e402f94f2117f633ea;hp=355cc36449f663ce8591f62e70aaa969c11ef31f;hb=ac5c933bdd463558e8d621507a53a7b247a9093e;hpb=5fb67d522575fa73fb6e291dd6d2fce8a69bf9e3

diff --git a/lib/Catalyst/Controller.pm b/lib/Catalyst/Controller.pm
index 355cc36..2e58312 100644
--- a/lib/Catalyst/Controller.pm
+++ b/lib/Catalyst/Controller.pm
@@ -1,31 +1,48 @@
 package Catalyst::Controller;
 
-use Moose;
+#switch to BEGIN { extends qw/ ... /; } ?
 use base qw/Catalyst::Component Catalyst::AttrContainer/;
-
-#Why does the following blow up?
-#extends qw/Catalyst::Component Catalyst::AttrContainer/;
-
-has path => (
-             is => 'ro',
-             isa => 'Str',
-             predicate => 'has_path',
-            );
-
-#this are frefixed like this because _namespace clases with something in
-#Catalyst.pm . to be fixed later.
-has _namespace => (
-                   is => 'ro',
-                   isa => 'Str',
-                   init_arg => 'namespace',
-                   predicate => '_has_namespace',
-                 );
+use Moose;
 
 use Scalar::Util qw/blessed/;
 use Catalyst::Exception;
 use Catalyst::Utils;
 use Class::Inspector;
-use NEXT;
+
+has path_prefix =>
+    (
+     is => 'ro',
+     isa => 'Str',
+     init_arg => 'path',
+     predicate => 'has_path_prefix',
+    );
+
+has action_namespace =>
+    (
+     is => 'ro',
+     isa => 'Str',
+     init_arg => 'namespace',
+     predicate => 'has_action_namespace',
+    );
+
+has actions =>
+    (
+     is => 'rw',
+     isa => 'HashRef',
+     init_arg => undef,
+    );
+
+# isa => 'ClassName|Catalyst' ?
+has _application => (is => 'rw');
+sub _app{ shift->_application(@_) } # eww
+
+sub BUILD {
+    my ($self, $args) = @_;
+    my $action  = delete $args->{action}  || {};
+    my $actions = delete $args->{actions} || {};
+    my $attr_value = $self->merge_config_hashes($actions, $action);
+    $self->actions($attr_value);
+}
 
 =head1 NAME
 
@@ -36,9 +53,9 @@ Catalyst::Controller - Catalyst Controller base class
   package MyApp::Controller::Search
   use base qw/Catalyst::Controller/;
 
-  sub foo : Local {
+  sub foo : Local { 
     my ($self,$c,@args) = @_;
-    ...
+    ... 
   } # Dispatches to /search/foo
 
 =head1 DESCRIPTION
@@ -50,17 +67,13 @@ for more info about how Catalyst dispatches to actions.
 
 =cut
 
+#I think both of these could be attributes. doesn't really seem like they need
+#to ble class data. i think that attributes +default would work just fine
 __PACKAGE__->mk_classdata($_) for qw/_dispatch_steps _action_class/;
 
 __PACKAGE__->_dispatch_steps( [qw/_BEGIN _AUTO _ACTION/] );
 __PACKAGE__->_action_class('Catalyst::Action');
 
-__PACKAGE__->mk_accessors( qw/_application/ );
-
-### _app as alias
-sub _app{ shift->_application }
-#for now.
-#*_app = *_application;
 
 sub _DISPATCH : Private {
     my ( $self, $c ) = @_;
@@ -118,40 +131,53 @@ around new => sub {
     return $new;
 };
 
-
 sub action_for {
     my ( $self, $name ) = @_;
     my $app = ($self->isa('Catalyst') ? $self : $self->_application);
     return $app->dispatcher->get_action($name, $self->action_namespace);
 }
 
-sub action_namespace {
-    my ( $self, $c ) = @_;
-    unless ( $c ) {
-        $c = ($self->isa('Catalyst') ? $self : $self->_application);
-    }
+around action_namespace => sub {
+    my ( $orig, $self, $c ) = @_;
+
     if( ref($self) ){
-      return $self->_namespace if $self->_has_namespace;
-    } # else {
-      return $self->config->{namespace} if exists $self->config->{namespace};
-    #}
-    return Catalyst::Utils::class2prefix( ref($self) || $self,
-        $c->config->{case_sensitive} )
-      || '';
-}
+        return $self->$orig if $self->has_action_namespace;
+    } else {
+        return $self->config->{namespace} if exists $self->config->{namespace};
+    }
 
-sub path_prefix {
-    my ( $self, $c ) = @_;
-    unless ( $c ) {
-        $c = ($self->isa('Catalyst') ? $self : $self->_application);
+    #the following looks like a possible target for a default setting. i am not
+    #making the below the builder because i don't know if $c will vary from
+    #call to call, which would affect case sensitivitysettings -- groditi
+    my $case_s;
+    if( $c ){
+        $case_s = $c->config->{case_sensitive};
+    } else {
+        if ($self->isa('Catalyst')) {
+            $case_s = $self->config->{case_sensitive};
+        } else {
+            if (ref $self) {
+                $case_s = $self->_application->config->{case_sensitive};
+            } else {
+                confess("Can't figure out case_sensitive setting");
+            }
+        }
     }
+
+    return Catalyst::Utils::class2prefix(ref($self) || $self, $case_s) || '';
+};
+
+
+around path_prefix => sub {
+    my $orig = shift;
+    my $self = shift;
     if( ref($self) ){
-      return $self->path if $self->has_path;
-    } # else {
+      return $self->$orig if $self->has_path_prefix;
+    } else {
       return $self->config->{path} if exists $self->config->{path};
-    #}
-    return shift->action_namespace(@_);
-}
+    }
+    return $self->action_namespace(@_);
+};
 
 
 sub register_actions {
@@ -163,7 +189,7 @@ sub register_actions {
     if( $self->can('meta') ){
       my $meta = $self->meta;
       %methods = map{ $_->{code}->body => $_->{name} }
-        grep {$_->{class} ne 'Moose::Object'}
+        grep {$_->{class} ne 'Moose::Object'} #ignore Moose::Object methods
           $meta->compute_all_applicable_methods;
     } else { #until we are sure there's no moose stuff left...
       $methods{ $self->can($_) } = $_
@@ -172,6 +198,7 @@ sub register_actions {
 
     # Advanced inheritance support for plugins and the like
     #to be modified to use meta->superclasses
+    #moose todo: migrate to eliminate CDI compat
     my @action_cache;
     {
         no strict 'refs';
@@ -215,10 +242,7 @@ sub create_action {
                     ? $args{attributes}{ActionClass}[0]
                     : $self->_action_class);
 
-    unless ( Class::Inspector->loaded($class) ) {
-        require Class::Inspector->filename($class);
-    }
-
+    Class::MOP::load_class($class);
     return $class->new( \%args );
 }
 
@@ -241,17 +265,24 @@ sub _parse_attrs {
         }
     }
 
-    #this will not work under moose
-    #my $hash = (ref $self ? $self : $self->config); # hate app-is-class
-    my $hash = $self->config;
-
-    if (exists $hash->{actions} || exists $hash->{action}) {
-      my $a = $hash->{actions} || $hash->{action};
-      %raw_attributes = ((exists $a->{'*'} ? %{$a->{'*'}} : ()),
-                         %raw_attributes,
-                         (exists $a->{$name} ? %{$a->{$name}} : ()));
+    #I know that the original behavior was to ignore action if actions was set
+    # but i actually think this may be a little more sane? we can always remove
+    # the merge behavior quite easily and go back to having actions have
+    # presedence over action by modifying the keys. i honestly think this is
+    # superior while mantaining really high degree of compat
+    my $actions;
+    if( ref($self) ) {
+        $actions = $self->actions;
+    } else {
+        my $cfg = $self->config;
+        $actions = $self->merge_config_hashes($cfg->{actions}, $cfg->{action});
     }
 
+    %raw_attributes = ((exists $actions->{'*'} ? %{$actions->{'*'}} : ()),
+                       %raw_attributes,
+                       (exists $actions->{$name} ? %{$actions->{$name}} : ()));
+
+
     my %final_attributes;
 
     foreach my $key (keys %raw_attributes) {
@@ -261,8 +292,8 @@ sub _parse_attrs {
         foreach my $value (ref($raw) eq 'ARRAY' ? @$raw : $raw) {
 
             my $meth = "_parse_${key}_attr";
-            if ( $self->can($meth) ) {
-                ( $key, $value ) = $self->$meth( $c, $name, $value );
+            if ( my $code = $self->can($meth) ) {
+                ( $key, $value ) = $self->$code( $c, $name, $value );
             }
             push( @{ $final_attributes{$key} }, $value );
         }
@@ -349,7 +380,7 @@ controller name. For instance controller 'MyApp::Controller::Foo::Bar'
 will be bound to 'foo/bar'. The default Root controller is an example
 of setting namespace to '' (the null string).
 
-=head2 path
+=head2 path 
 
 Sets 'path_prefix', as described below.