X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=lib%2FCatalyst%2FComponent.pm;h=be0d75854110b7a333142150b6ba2104ca846af1;hp=1f1fbb509f5b6cb0930dc59f4f6c3809c7b936e5;hb=43c581537432e9e6dd82d10375e1aac4cbcff5fb;hpb=2ef599586739f410da035904753378000a368a44 diff --git a/lib/Catalyst/Component.pm b/lib/Catalyst/Component.pm index 1f1fbb5..be0d758 100644 --- a/lib/Catalyst/Component.pm +++ b/lib/Catalyst/Component.pm @@ -2,8 +2,9 @@ package Catalyst::Component; use Moose; use Class::MOP; -use MooseX::Adopt::Class::Accessor::Fast; +use Class::MOP::Object; use Catalyst::Utils; +use Class::C3::Adopt::NEXT; use MRO::Compat; use mro 'c3'; @@ -33,7 +34,7 @@ Catalyst::Component - Catalyst Component Base Class my ( $self, $c ) = @_; $c->response->output( $self->{foo} ); } - + 1; # Methods can be a request step @@ -46,7 +47,7 @@ Catalyst::Component - Catalyst Component Base Class =head1 DESCRIPTION -This is the universal base class for Catalyst components +This is the universal base class for Catalyst components (Model/View/Controller). It provides you with a generic new() for instantiation through Catalyst's @@ -59,17 +60,15 @@ __PACKAGE__->mk_classdata('_config'); sub BUILDARGS { my ($self) = @_; - + # Temporary fix, some components does not pass context to constructor my $arguments = ( ref( $_[-1] ) eq 'HASH' ) ? $_[-1] : {}; my $args = $self->merge_config_hashes( $self->config, $arguments ); - + return $args; } -no Moose; - sub COMPONENT { my ( $self, $c ) = @_; @@ -78,8 +77,10 @@ sub COMPONENT { if( my $next = $self->next::can ){ my $class = blessed $self || $self; my ($next_package) = Class::MOP::get_code_info($next); - warn "There is a COMPONENT method resolving after Catalyst::Component in ${next_package}. This behavior is deprecated and will stop working in future releases."; - return $next->($self, $arguments); + warn "There is a COMPONENT method resolving after Catalyst::Component in ${next_package}.\n"; + warn "This behavior can no longer be supported, and so your application is probably broken.\n"; + warn "Your linearized isa hierarchy is: " . join(', ', @{ mro::get_linear_isa($class) }) . "\n"; + warn "Please see perldoc Catalyst::Upgrading for more information about this issue.\n"; } return $self->new($c, $arguments); } @@ -95,11 +96,10 @@ sub config { } else { # this is a bit of a kludge, required to make # __PACKAGE__->config->{foo} = 'bar'; - # work in a subclass. If we don't have the package symbol in the - # current class we know we need to copy up to ours, which calling - # the setter will do for us. - - unless ($self->meta->has_package_symbol('$_config')) { + # work in a subclass. + my $class = blessed($self) || $self; + my $meta = Class::MOP::get_metaclass_by_name($class); + unless ($meta->has_package_symbol('$_config')) { $config = $self->merge_config_hashes( $config, {} ); $self->_config( $config ); @@ -120,6 +120,7 @@ sub process { . " did not override Catalyst::Component::process" ); } +no Moose; __PACKAGE__->meta->make_immutable; 1; @@ -139,8 +140,8 @@ If this method is present (as it is on all Catalyst::Component subclasses, it is called by Catalyst during setup_components with the application class as $c and any config entry on the application for this component (for example, in the case of MyApp::Controller::Foo this would be -MyApp->config->{'Controller::Foo'}). The arguments are expected to be a -hashref and are merged with the __PACKAGE__->config hashref before calling +MyApp->config->{'Controller::Foo'}). The arguments are expected to be a +hashref and are merged with the __PACKAGE__->config hashref before calling ->new to instantiate the component. =head2 $c->config @@ -149,15 +150,15 @@ hashref and are merged with the __PACKAGE__->config hashref before calling =head2 $c->config($key, $value, ...) -Accessor for this component's config hash. Config values can be set as +Accessor for this component's config hash. Config values can be set as key value pair, or you can specify a hashref. In either case the keys -will be merged with any existing config settings. Each component in -a Catalyst application has it's own config hash. +will be merged with any existing config settings. Each component in +a Catalyst application has its own config hash. =head2 $c->process() This is the default method called on a Catalyst component in the dispatcher. -For instance, Views implement this action to render the response body +For instance, Views implement this action to render the response body when you forward to them. The default is an abstract method. =head2 $c->merge_config_hashes( $hashref, $hashref ) @@ -169,7 +170,7 @@ Alias for the method in L. =head2 ACCEPT_CONTEXT($c, @args) -Catalyst components are normally initalized during server startup, either +Catalyst components are normally initialized during server startup, either as a Class or a Instance. However, some components require information about the current request. To do so, they can implement an ACCEPT_CONTEXT method. @@ -183,11 +184,9 @@ calling code in the application rather than the component itself. L, L, L, L. -=head1 AUTHOR +=head1 AUTHORS -Sebastian Riedel, C -Marcus Ramberg, C -Matt S Trout, C +Catalyst Contributors, see Catalyst.pm =head1 COPYRIGHT