X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=lib%2FCatalyst%2FClassData.pm;h=99428403c288470e2a435c08abd572bac810fabd;hp=954d777d77a42362f17487237ccc86040880909f;hb=df960201c8d8c22edddedced4471c14606877145;hpb=4aa4c017da03300e96033ec7fa81b653b0aa2bea diff --git a/lib/Catalyst/ClassData.pm b/lib/Catalyst/ClassData.pm index 954d777..9942840 100644 --- a/lib/Catalyst/ClassData.pm +++ b/lib/Catalyst/ClassData.pm @@ -1,19 +1,20 @@ package Catalyst::ClassData; use Moose::Role; +use Moose::Meta::Class (); use Class::MOP; -use Class::MOP::Object; +use Moose::Util (); sub mk_classdata { - my ($class, $attribute) = @_; + my ($class, $attribute, $warn_on_instance) = @_; confess("mk_classdata() is a class method, not an object method") if blessed $class; my $slot = '$'.$attribute; my $accessor = sub { my $pkg = ref $_[0] || $_[0]; - # Hack - delberately create a metaclass instance - my $meta = $pkg->Moose::Object::meta(); + my $meta = Moose::Util::find_meta($pkg) + || Moose::Meta::Class->initialize( $pkg ); if (@_ > 1) { $meta->namespace->{$attribute} = \$_[1]; return $_[1]; @@ -44,17 +45,18 @@ sub mk_classdata { unless ref $accessor eq 'CODE'; my $meta = $class->Class::MOP::Object::meta(); - my $immutable_options; - if( $meta->is_immutable ){ - $immutable_options = $meta->get_immutable_options; - $meta->make_mutable; - } + confess "${class}'s metaclass is not a Class::MOP::Class" + unless $meta->isa('Class::MOP::Class'); + + my $was_immutable = $meta->is_immutable; + $meta->make_mutable if $was_immutable; + my $alias = "_${attribute}_accessor"; $meta->add_method($alias, $accessor); $meta->add_method($attribute, $accessor); - if(defined $immutable_options){ - $meta->make_immutable(%{ $immutable_options }); - } + + $meta->make_immutable if $was_immutable; + $class->$attribute($_[2]) if(@_ > 2); return $accessor; } @@ -81,7 +83,7 @@ Guillermo Roditi =head1 COPYRIGHT -This program is free software, you can redistribute it and/or modify it under +This library is free software. You can redistribute it and/or modify it under the same terms as Perl itself. =cut