X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=lib%2FCatalyst%2FBase.pm;h=789c6ab9f987b41334456a1761e787f5c9e36946;hp=ec25476b1b70be7a35ff129bd0f34eaba48c71fa;hb=74dafab798a163c251e09de7fcc21a267d1678a6;hpb=4f6748f101647dd3344339b19510947df6836412 diff --git a/lib/Catalyst/Base.pm b/lib/Catalyst/Base.pm index ec25476..789c6ab 100644 --- a/lib/Catalyst/Base.pm +++ b/lib/Catalyst/Base.pm @@ -2,22 +2,23 @@ package Catalyst::Base; use strict; use base qw/Class::Data::Inheritable Class::Accessor::Fast/; -use Catalyst::Utils; + +use Catalyst::Exception; use NEXT; -__PACKAGE__->mk_classdata($_) for qw/_attrcache _cache _config/; -__PACKAGE__->_attrcache( {} ); -__PACKAGE__->_cache( [] ); +__PACKAGE__->mk_classdata($_) for qw/_attr_cache _action_cache _config/; +__PACKAGE__->_attr_cache( {} ); +__PACKAGE__->_action_cache( [] ); # note - see attributes(3pm) sub MODIFY_CODE_ATTRIBUTES { my ( $class, $code, @attrs ) = @_; - $class->_attrcache->{$code} = [@attrs]; - push @{ $class->_cache }, [ $code, [@attrs] ]; + $class->_attr_cache->{$code} = [@attrs]; + push @{ $class->_action_cache }, [ $code, [@attrs] ]; return (); } -sub FETCH_CODE_ATTRIBUTES { $_[0]->_attrcache->{ $_[1] } || () } +sub FETCH_CODE_ATTRIBUTES { $_[0]->_attr_cache->{ $_[1] } || () } =head1 NAME @@ -70,12 +71,11 @@ component loader with config() support and a process() method placeholder. sub new { my ( $self, $c ) = @_; - my $class = ref $self || $self; - my $appname = Catalyst::Utils::class2appclass($class); - my $suffix = Catalyst::Utils::class2classsuffix($class); - my $appconfig = $appname->config->{$suffix} || {}; - my $config = { %{ $self->config }, %{$appconfig} }; - return $self->NEXT::new($config); + + # Temporary fix, some components does not pass context to constructor + my $arguments = ( ref( $_[-1] ) eq 'HASH' ) ? $_[-1] : {}; + + return $self->NEXT::new( { %{ $self->config }, %{ $arguments } } ); } # remember to leave blank lines between the consecutive =item's @@ -92,8 +92,8 @@ sub new { sub config { my $self = shift; $self->_config( {} ) unless $self->_config; - if ( $_[0] ) { - my $config = $_[1] ? {@_} : $_[0]; + if (@_) { + my $config = @_ > 1 ? {@_} : $_[0]; while ( my ( $key, $val ) = each %$config ) { $self->_config->{$key} = $val; } @@ -106,9 +106,16 @@ sub config { =cut sub process { - die( ( ref $_[0] || $_[0] ) . " did not override Catalyst::Base::process" ); + + Catalyst::Exception->throw( + message => ( ref $_[0] || $_[0] ) . " did not override Catalyst::Base::process" + ); } +=item FETCH_CODE_ATTRIBUTES + +=item MODIFY_CODE_ATTRIBUTES + =back =head1 SEE ALSO