X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=lib%2FCatalyst%2FAction.pm;h=9815391eb627fca36c04d8f08251d089dc0d4b8c;hp=01c05646c3f24c0a432bdda51d982d4c07ec58ff;hb=7fa2c9c1b85c98786655ad5169708d8dc84e8353;hpb=85d9fce671016c9040775c8b4458cf9c72ec2208 diff --git a/lib/Catalyst/Action.pm b/lib/Catalyst/Action.pm index 01c0564..9815391 100644 --- a/lib/Catalyst/Action.pm +++ b/lib/Catalyst/Action.pm @@ -1,9 +1,5 @@ package Catalyst::Action; -use strict; -use base qw/Class::Accessor::Fast/; - - =head1 NAME Catalyst::Action - Catalyst Action @@ -14,19 +10,32 @@ Catalyst::Action - Catalyst Action =head1 DESCRIPTION -This class represents a Catalyst Action. You can access the object for the +This class represents a Catalyst Action. You can access the object for the currently dispatched action via $c->action. See the L for more information on how actions are dispatched. Actions are defined in L subclasses. =cut -__PACKAGE__->mk_accessors(qw/class namespace reverse attributes name code/); +use Moose; + +has class => (is => 'rw'); +has namespace => (is => 'rw'); +has 'reverse' => (is => 'rw'); +has attributes => (is => 'rw'); +has name => (is => 'rw'); +has code => (is => 'rw'); + +no Moose; + +no warnings 'recursion'; + +#__PACKAGE__->mk_accessors(qw/class namespace reverse attributes name code/); use overload ( # Stringify to reverse for debug output etc. - q{""} => sub { shift->{reverse} }, + q{""} => sub { shift->reverse() }, # Codulate to execute to invoke the encapsulated action coderef '&{}' => sub { my $self = shift; sub { $self->execute(@_); }; }, @@ -38,13 +47,22 @@ use overload ( sub dispatch { # Execute ourselves against a context my ( $self, $c ) = @_; - local $c->namespace = $self->namespace; + #Moose todo: grrrrrr. this is no good. i don't know enough about it to + # debug it though. why can't we just call the accessor? + local $c->{namespace} = $self->namespace; return $c->execute( $self->class, $self ); + + #believed to be equivalent: + #my $orig = $c->namespace; + #$c->namespace($self->namespace); + #my $ret = $c->execute( $self->class, $self ); + #$c->namespace($orig); + #return $ret; } sub execute { my $self = shift; - $self->{code}->(@_); + $self->code->(@_); } sub match { @@ -100,6 +118,10 @@ Returns the private path for this action. returns the sub name of this action. +=head2 meta + +Provided by Moose + =head1 AUTHOR Matt S. Trout