X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2FCatalyst-Runtime.git;a=blobdiff_plain;f=lib%2FCatalyst.pm;h=6c1ef1eb4d65a218b74a351d440be4fda3d25ed8;hp=cec982f0dc1bf1442b666237b32d9f7409815684;hb=f7f55b2f120335b9c3ff53cc7f45378241d884c3;hpb=8f076801b5c41543fdc20859452ed2cea1e1f82f diff --git a/lib/Catalyst.pm b/lib/Catalyst.pm index cec982f..6c1ef1e 100644 --- a/lib/Catalyst.pm +++ b/lib/Catalyst.pm @@ -34,6 +34,9 @@ use Catalyst::EngineLoader; use utf8; use Carp qw/croak carp shortmess/; use Try::Tiny; +use Plack::Middleware::Conditional; +use Plack::Middleware::ReverseProxy; +use Plack::Middleware::IIS6ScriptNameFix; BEGIN { require 5.008004; } @@ -81,7 +84,7 @@ __PACKAGE__->stats_class('Catalyst::Stats'); # Remember to update this in Catalyst::Runtime as well! -our $VERSION = '5.89001'; +our $VERSION = '5.89002'; sub import { my ( $class, @arguments ) = @_; @@ -2642,7 +2645,7 @@ sub _setup_psgi_app { if -e $psgi_file; } - return $app->_wrapped_legacy_psgi_app; + return $app->_wrapped_legacy_psgi_app($app->psgi_app); } # Note - this is for back compatibility. Catalyst should not know or care about @@ -2650,10 +2653,10 @@ sub _setup_psgi_app { # use the ReverseProxy middleware yourself if you want it in a .psgi # file. sub _wrapped_legacy_psgi_app { - my ($app) = @_; + my ($app, $psgi_app) = @_; - return Plack::Middleware::Conditional->wrap( - $app->psgi_app, + $psgi_app = Plack::Middleware::Conditional->wrap( + $psgi_app, builder => sub { Plack::Middleware::ReverseProxy->wrap($_[0]) }, condition => sub { my ($env) = @_; @@ -2662,6 +2665,57 @@ sub _wrapped_legacy_psgi_app { || $app->config->{using_frontend_proxy}; }, ); + + my $server_matches = sub { + my ($re) = @_; + return sub { + my ($env) = @_; + my $server = $env->{SERVER_SOFTWARE}; + return unless $server; + return $server =~ $re ? 1 : 0; + }; + }; + + # If we're running under Lighttpd, swap PATH_INFO and SCRIPT_NAME + # http://lists.scsys.co.uk/pipermail/catalyst/2006-June/008361.html + # Thanks to Mark Blythe for this fix + # + # Note that this has probably the same effect as + # Plack::Middleware::LighttpdScriptNameFix and we should switch to that if + # we can. + $psgi_app = Plack::Middleware::Conditional->wrap( + $psgi_app, + condition => $server_matches->(qr/lighttpd/), + builder => sub { + my ($to_wrap) = @_; + return sub { + my ($env) = @_; + $env->{PATH_INFO} ||= delete $env->{SCRIPT_NAME}; + return $to_wrap->($env); + }; + }, + ); + + $psgi_app = Plack::Middleware::Conditional->wrap( + $psgi_app, + condition => $server_matches->(qr/^nginx/), + builder => sub { + my ($to_wrap) = @_; + return sub { + my ($env) = @_; + my $script_name = $env->{SCRIPT_NAME}; + $env->{PATH_INFO} =~ s/^$script_name//g; + return $to_wrap->($env); + }; + }, + ); + + # we're applying this unconditionally as the middleware itself already makes + # sure it doesn't fuck things up if it's not running under one of the right + # IIS versions + $psgi_app = Plack::Middleware::IIS6ScriptNameFix->wrap($psgi_app); + + return $psgi_app; } =head2 $c->psgi_app